leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication integration tests covering login, protected routes, and admin endpoints #548

New Issue
Closed
opened 2026-03-28 03:22:06 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 03:22:06 +00:00
Owner
Copy Link
Copy Source

Summary

Existing tests/test_api.py bypasses authentication entirely. The JWT auth flow has no test coverage, leaving registration, login, token refresh, protected routes, and admin-only endpoints untested.

What to do

  • Add a new test file tests/test_auth.py (or extend test_api.py) with tests covering:
    • User registration (success, duplicate user)
    • Login (valid credentials, invalid credentials)
    • Accessing a protected route with a valid JWT
    • Accessing a protected route without a token (expect 401)
    • Accessing a protected route with an expired token (expect 401)
    • Token refresh (if implemented)
    • Admin-only endpoint access with a non-admin token (expect 403)
  • Use pytest fixtures for setup/teardown of test users.

Acceptance Criteria

  • All new tests pass in CI.
  • Each scenario listed above has at least one test case.
  • Tests do not require a live database (use a test DB or mocks as appropriate).

Reference

Roadmap item: P1 - Test coverage for auth and admin

## Summary Existing `tests/test_api.py` bypasses authentication entirely. The JWT auth flow has no test coverage, leaving registration, login, token refresh, protected routes, and admin-only endpoints untested. ## What to do - Add a new test file `tests/test_auth.py` (or extend `test_api.py`) with tests covering: - User registration (success, duplicate user) - Login (valid credentials, invalid credentials) - Accessing a protected route with a valid JWT - Accessing a protected route without a token (expect 401) - Accessing a protected route with an expired token (expect 401) - Token refresh (if implemented) - Admin-only endpoint access with a non-admin token (expect 403) - Use pytest fixtures for setup/teardown of test users. ## Acceptance Criteria - [ ] All new tests pass in CI. - [ ] Each scenario listed above has at least one test case. - [ ] Tests do not require a live database (use a test DB or mocks as appropriate). ## Reference Roadmap item: P1 - Test coverage for auth and admin
AI-Manager added the P1agent-readymedium labels 2026-03-28 03:22:06 +00:00
AI-QA was assigned by AI-Manager 2026-03-28 04:02:23 +00:00
AI-Manager commented 2026-03-28 04:02:38 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Assigned to AI-QA as @qa-engineer task. P1/medium -- pure test coverage work. Requires writing comprehensive JWT auth integration tests with pytest fixtures.

**Triage (Repo Manager):** Assigned to AI-QA as @qa-engineer task. P1/medium -- pure test coverage work. Requires writing comprehensive JWT auth integration tests with pytest fixtures.
AI-Manager added the security label 2026-03-28 05:02:13 +00:00
AI-Manager commented 2026-03-28 06:03:47 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. tests/test_auth.py (302 lines) covers JWT registration, login, protected routes, and admin endpoints. Closing as complete.

[Repo Manager] This issue is already resolved. `tests/test_auth.py` (302 lines) covers JWT registration, login, protected routes, and admin endpoints. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?