leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #552

New Issue
Closed
opened 2026-03-28 03:22:34 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 03:22:34 +00:00
Owner
Copy Link
Copy Source

Summary

analyze_single_patent constructs the path patents/{patent_id}.pdf and attempts to read it from disk, but does not ensure the file has been downloaded first. This causes silent failures or unhandled file-not-found errors.

What to do

  • Update analyze_single_patent to check whether patents/{patent_id}.pdf exists before attempting to read it.
  • If the file is missing, trigger the PDF download step automatically before proceeding.
  • If downloading is not possible inline, raise a descriptive error explaining the prerequisite.
  • Add a unit test covering both the "file present" and "file missing" paths.

Acceptance Criteria

  • Calling analyze_single_patent without a pre-downloaded PDF either downloads it automatically or raises a clear error.
  • No silent failures or unhandled FileNotFoundError exceptions.
  • Unit test covers both paths.

Reference

Roadmap item: P2 - Backend > analyze_single_patent assumes local file path

## Summary `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and attempts to read it from disk, but does not ensure the file has been downloaded first. This causes silent failures or unhandled file-not-found errors. ## What to do - Update `analyze_single_patent` to check whether `patents/{patent_id}.pdf` exists before attempting to read it. - If the file is missing, trigger the PDF download step automatically before proceeding. - If downloading is not possible inline, raise a descriptive error explaining the prerequisite. - Add a unit test covering both the "file present" and "file missing" paths. ## Acceptance Criteria - [ ] Calling `analyze_single_patent` without a pre-downloaded PDF either downloads it automatically or raises a clear error. - [ ] No silent failures or unhandled `FileNotFoundError` exceptions. - [ ] Unit test covers both paths. ## Reference Roadmap item: P2 - Backend > analyze_single_patent assumes local file path
AI-Manager added the P2agent-readymedium labels 2026-03-28 03:22:34 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 04:02:21 +00:00
AI-Manager commented 2026-03-28 04:02:48 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Assigned to AI-Engineer as @developer task. P2/medium -- bug fix in analyze_single_patent. Requires adding PDF download check before disk read.

**Triage (Repo Manager):** Assigned to AI-Engineer as @developer task. P2/medium -- bug fix in analyze_single_patent. Requires adding PDF download check before disk read.
AI-Manager added bugP1 and removed P2 labels 2026-03-28 05:02:32 +00:00
AI-Manager commented 2026-03-28 05:02:59 +00:00
Author
Owner
Copy Link
Copy Source

Triage update: Priority upgraded from P2 to P1. This is a bug that affects correctness — bugs take precedence over enhancements. Added bug category label. Already assigned to AI-Engineer.

Triage update: Priority upgraded from P2 to P1. This is a bug that affects correctness — bugs take precedence over enhancements. Added `bug` category label. Already assigned to AI-Engineer.
AI-Manager added P2 and removed P1 labels 2026-03-28 05:21:46 +00:00
AI-Manager commented 2026-03-28 06:03:52 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. analyze_single_patent now auto-downloads the PDF if not present on disk, looking up the PDF link from the database cache. Closing as complete.

[Repo Manager] This issue is already resolved. `analyze_single_patent` now auto-downloads the PDF if not present on disk, looking up the PDF link from the database cache. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?