leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #557

New Issue
Closed
opened 2026-03-28 03:23:12 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 03:23:12 +00:00
Owner
Copy Link
Copy Source

Summary

The CI pipeline has no linting or type checking step. Code style issues and TypeScript type errors can be merged undetected.

What to do

  • Add a lint job (or extend the test job) in the CI workflow:
    • Run ruff check . on the Python backend.
    • Run tsc --noEmit on the TypeScript frontend.
  • Ensure the job fails on any lint or type error.
  • Add ruff to backend dev dependencies (e.g. requirements-dev.txt).
  • Configure ruff with a pyproject.toml or ruff.toml if not already present.

Acceptance Criteria

  • CI runs ruff check on the backend and fails on lint errors.
  • CI runs tsc --noEmit on the frontend and fails on type errors.
  • Both checks run on every push and PR.

Reference

Roadmap item: P2 - CI/CD > No linting or type checking

## Summary The CI pipeline has no linting or type checking step. Code style issues and TypeScript type errors can be merged undetected. ## What to do - Add a `lint` job (or extend the `test` job) in the CI workflow: - Run `ruff check .` on the Python backend. - Run `tsc --noEmit` on the TypeScript frontend. - Ensure the job fails on any lint or type error. - Add `ruff` to backend dev dependencies (e.g. `requirements-dev.txt`). - Configure `ruff` with a `pyproject.toml` or `ruff.toml` if not already present. ## Acceptance Criteria - [ ] CI runs `ruff check` on the backend and fails on lint errors. - [ ] CI runs `tsc --noEmit` on the frontend and fails on type errors. - [ ] Both checks run on every push and PR. ## Reference Roadmap item: P2 - CI/CD > No linting or type checking
AI-Manager added the P2agent-readymedium labels 2026-03-28 03:23:12 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 04:02:22 +00:00
AI-Manager commented 2026-03-28 04:02:48 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Assigned to AI-Engineer as @devops task. P2/medium -- CI pipeline enhancement adding ruff and tsc linting steps.

**Triage (Repo Manager):** Assigned to AI-Engineer as @devops task. P2/medium -- CI pipeline enhancement adding ruff and tsc linting steps.
AI-Manager added the infra label 2026-03-28 05:02:13 +00:00
AI-Manager commented 2026-03-28 06:03:58 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. The CI workflow runs ruff check for Python and npx tsc --noEmit for TypeScript in the test job. Closing as complete.

[Repo Manager] This issue is already resolved. The CI workflow runs `ruff check` for Python and `npx tsc --noEmit` for TypeScript in the test job. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#557
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?