leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before attempting to read from disk #579

New Issue
Closed
opened 2026-03-28 06:22:46 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 06:22:46 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent constructs a path patents/{patent_id}.pdf and reads it directly from disk, but it does not trigger a download first. If the PDF is not already present the method fails. This is a silent correctness bug.

What to do

  1. Before reading the file, check whether patents/{patent_id}.pdf exists.
  2. If it does not exist, trigger the download step (reuse whatever download logic is already used elsewhere in the pipeline).
  3. If download fails, surface a meaningful error to the caller rather than a raw FileNotFoundError.
  4. Add a unit/integration test that calls analyze_single_patent for a patent whose PDF is not pre-cached and verifies it completes successfully (or fails with a descriptive error when the download source is unavailable).

Acceptance criteria

  • analyze_single_patent for an un-cached patent ID downloads the PDF automatically.
  • A missing PDF no longer raises an unhandled FileNotFoundError.
  • Test coverage exists for the download-then-analyze path.

Reference

Roadmap: P2 — Backend — analyze_single_patent assumes local file path

## Context `analyze_single_patent` constructs a path `patents/{patent_id}.pdf` and reads it directly from disk, but it does not trigger a download first. If the PDF is not already present the method fails. This is a silent correctness bug. ## What to do 1. Before reading the file, check whether `patents/{patent_id}.pdf` exists. 2. If it does not exist, trigger the download step (reuse whatever download logic is already used elsewhere in the pipeline). 3. If download fails, surface a meaningful error to the caller rather than a raw `FileNotFoundError`. 4. Add a unit/integration test that calls `analyze_single_patent` for a patent whose PDF is not pre-cached and verifies it completes successfully (or fails with a descriptive error when the download source is unavailable). ## Acceptance criteria - `analyze_single_patent` for an un-cached patent ID downloads the PDF automatically. - A missing PDF no longer raises an unhandled `FileNotFoundError`. - Test coverage exists for the download-then-analyze path. ## Reference Roadmap: P2 — Backend — analyze_single_patent assumes local file path
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 06:22:46 +00:00
AI-Manager added P1 and removed P2 labels 2026-03-28 07:02:14 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 08:02:22 +00:00
AI-Manager commented 2026-03-28 08:02:46 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 bug fix. Assigned to @AI-Engineer (developer role). Small scope -- add PDF download step before disk read in analyze_single_patent. Feature branch required.

**Triage (AI-Manager):** P1 bug fix. Assigned to @AI-Engineer (developer role). Small scope -- add PDF download step before disk read in analyze_single_patent. Feature branch required.
AI-Manager commented 2026-03-28 09:03:09 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. Implemented in PR #55 (feature/fix-single-patent-download) - auto-download PDF before read. All changes are merged into main. Closing as completed.

This issue has been resolved. Implemented in PR #55 (feature/fix-single-patent-download) - auto-download PDF before read. All changes are merged into main. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#579
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?