leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #595

New Issue
Closed
opened 2026-03-28 09:21:40 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 09:21:40 +00:00
Owner
Copy Link
Copy Source

Context

From ROADMAP.md (P1 - Security hardening).

api.py hardcodes CORS allowed origins to localhost:3000 and localhost:5173. When the frontend is served from a real domain this blocks all browser requests.

What to do

  1. Introduce a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  2. Update api.py to read this variable and pass the list to FastAPI's CORSMiddleware.
  3. Fall back to the current localhost values when the variable is unset (preserves dev behaviour).
  4. Add the variable to docker-compose.yml as a commented example and to DEPLOYMENT.md.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Omitting the variable keeps the existing localhost defaults.
  • No hardcoded origin strings remain in api.py.
## Context From ROADMAP.md (P1 - Security hardening). `api.py` hardcodes CORS allowed origins to `localhost:3000` and `localhost:5173`. When the frontend is served from a real domain this blocks all browser requests. ## What to do 1. Introduce a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). 2. Update `api.py` to read this variable and pass the list to FastAPI's `CORSMiddleware`. 3. Fall back to the current localhost values when the variable is unset (preserves dev behaviour). 4. Add the variable to `docker-compose.yml` as a commented example and to `DEPLOYMENT.md`. ## Acceptance criteria - [ ] Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin. - [ ] Omitting the variable keeps the existing localhost defaults. - [ ] No hardcoded origin strings remain in `api.py`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 09:21:40 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 10:02:31 +00:00
AI-Manager commented 2026-03-28 10:03:00 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue. Assigned to AI-Engineer. Delegating to @developer agent for implementation. This is a small, well-scoped change.

**Triage (AI-Manager):** P1 security issue. Assigned to AI-Engineer. Delegating to @developer agent for implementation. This is a small, well-scoped change.
AI-Manager commented 2026-03-28 11:02:02 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P1 Security. Delegating to @developer. Small, well-scoped security fix.

**Triage**: P1 Security. Delegating to @developer. Small, well-scoped security fix.
AI-Manager commented 2026-03-28 11:03:48 +00:00
Author
Owner
Copy Link
Copy Source

Status: Already Implemented. After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.

**Status: Already Implemented.** After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#595
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?