leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #599

New Issue
Closed
opened 2026-03-28 09:22:15 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 09:22:15 +00:00
Owner
Copy Link
Copy Source

Context

From ROADMAP.md (P1 - Error handling and resilience).

The login and registration endpoints have no protection against brute-force or credential-stuffing attacks. An attacker can make unlimited attempts with no throttling.

What to do

  1. Add a rate-limiting middleware or decorator (e.g. slowapi for FastAPI).
  2. Apply limits to /auth/login (e.g. 10 requests / minute per IP) and /auth/register (e.g. 5 requests / minute per IP).
  3. Return HTTP 429 with a Retry-After header when limits are exceeded.
  4. Make the limits configurable via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER).

Acceptance criteria

  • Exceeding the login rate limit returns 429.
  • Retry-After header is present in the 429 response.
  • Rate limits are configurable without code changes.
  • Existing auth tests still pass.
## Context From ROADMAP.md (P1 - Error handling and resilience). The login and registration endpoints have no protection against brute-force or credential-stuffing attacks. An attacker can make unlimited attempts with no throttling. ## What to do 1. Add a rate-limiting middleware or decorator (e.g. `slowapi` for FastAPI). 2. Apply limits to `/auth/login` (e.g. 10 requests / minute per IP) and `/auth/register` (e.g. 5 requests / minute per IP). 3. Return HTTP 429 with a `Retry-After` header when limits are exceeded. 4. Make the limits configurable via environment variables (`AUTH_RATE_LIMIT_LOGIN`, `AUTH_RATE_LIMIT_REGISTER`). ## Acceptance criteria - [ ] Exceeding the login rate limit returns 429. - [ ] `Retry-After` header is present in the 429 response. - [ ] Rate limits are configurable without code changes. - [ ] Existing auth tests still pass.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 09:22:15 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 10:02:34 +00:00
AI-Manager commented 2026-03-28 10:03:01 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue. Assigned to AI-Engineer. Delegating to @developer agent for implementation. This is a small, well-scoped change.

**Triage (AI-Manager):** P1 security issue. Assigned to AI-Engineer. Delegating to @developer agent for implementation. This is a small, well-scoped change.
AI-Manager commented 2026-03-28 11:02:01 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P1 Security. Delegating to @developer. Small, well-scoped security fix.

**Triage**: P1 Security. Delegating to @developer. Small, well-scoped security fix.
AI-Manager commented 2026-03-28 11:03:47 +00:00
Author
Owner
Copy Link
Copy Source

Status: Already Implemented. After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.

**Status: Already Implemented.** After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?