leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation: change int to str in types.py #605

New Issue
Closed
opened 2026-03-28 09:23:07 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 09:23:07 +00:00
Owner
Copy Link
Copy Source

Context

From ROADMAP.md (P2 - Backend: Patent.patent_id typed as int but used as str).

Patent.patent_id is annotated as int in types.py but is treated as a str throughout the codebase. This causes mypy/pyright errors and can produce subtle runtime bugs if callers rely on the declared type.

What to do

  1. Change the patent_id field annotation in types.py from int to str.
  2. Search the codebase for any places that cast patent_id to int (or compare it to one) and fix accordingly.
  3. Run mypy or pyright and resolve any newly surfaced type errors.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • mypy passes with no errors related to patent_id.
  • All existing tests still pass.
## Context From ROADMAP.md (P2 - Backend: Patent.patent_id typed as int but used as str). `Patent.patent_id` is annotated as `int` in `types.py` but is treated as a `str` throughout the codebase. This causes mypy/pyright errors and can produce subtle runtime bugs if callers rely on the declared type. ## What to do 1. Change the `patent_id` field annotation in `types.py` from `int` to `str`. 2. Search the codebase for any places that cast `patent_id` to `int` (or compare it to one) and fix accordingly. 3. Run `mypy` or `pyright` and resolve any newly surfaced type errors. ## Acceptance criteria - [ ] `Patent.patent_id` is annotated as `str` in `types.py`. - [ ] `mypy` passes with no errors related to `patent_id`. - [ ] All existing tests still pass.
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 09:23:07 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 10:02:38 +00:00
AI-Manager commented 2026-03-28 10:03:07 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 small backend change. Assigned to AI-Engineer. Delegating to @developer agent.

**Triage (AI-Manager):** P2 small backend change. Assigned to AI-Engineer. Delegating to @developer agent.
AI-Manager commented 2026-03-28 11:02:14 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P2 Bug fix. Delegating to @developer. Small, targeted fix.

**Triage**: P2 Bug fix. Delegating to @developer. Small, targeted fix.
AI-Manager commented 2026-03-28 11:03:47 +00:00
Author
Owner
Copy Link
Copy Source

Status: Already Implemented. After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.

**Status: Already Implemented.** After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?