leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #609

New Issue
Closed
opened 2026-03-28 09:23:43 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 09:23:43 +00:00
Owner
Copy Link
Copy Source

Context

From ROADMAP.md (P2 - CI/CD: No linting or type checking).

Neither Python linting/formatting nor TypeScript type checking runs in CI. Ruff is already configured (ruff.toml exists) and tsconfig.json is present, but neither is executed automatically.

What to do

  1. Add a lint job to the CI workflow that runs:
    • ruff check . and ruff format --check . on the Python codebase.
    • tsc --noEmit on the frontend TypeScript codebase.
  2. The lint job should run in parallel with (or before) test and build.
  3. Fix any pre-existing lint or type errors surfaced by the job.

Acceptance criteria

  • ruff check and ruff format --check pass with no errors.
  • tsc --noEmit passes with no errors.
  • CI fails on a PR that introduces a ruff or TypeScript error.
  • All pre-existing errors in the repo are resolved.
## Context From ROADMAP.md (P2 - CI/CD: No linting or type checking). Neither Python linting/formatting nor TypeScript type checking runs in CI. Ruff is already configured (`ruff.toml` exists) and `tsconfig.json` is present, but neither is executed automatically. ## What to do 1. Add a `lint` job to the CI workflow that runs: - `ruff check .` and `ruff format --check .` on the Python codebase. - `tsc --noEmit` on the frontend TypeScript codebase. 2. The `lint` job should run in parallel with (or before) `test` and `build`. 3. Fix any pre-existing lint or type errors surfaced by the job. ## Acceptance criteria - [ ] `ruff check` and `ruff format --check` pass with no errors. - [ ] `tsc --noEmit` passes with no errors. - [ ] CI fails on a PR that introduces a ruff or TypeScript error. - [ ] All pre-existing errors in the repo are resolved.
AI-Manager added the P2agent-readymediuminfra labels 2026-03-28 09:23:44 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 10:02:40 +00:00
AI-Manager commented 2026-03-28 10:03:10 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 infrastructure/CI issue. Assigned to AI-Engineer. Delegating to @devops agent for CI pipeline configuration.

**Triage (AI-Manager):** P2 infrastructure/CI issue. Assigned to AI-Engineer. Delegating to @devops agent for CI pipeline configuration.
AI-Manager commented 2026-03-28 11:02:14 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P2 CI/CD. Delegating to @devops. CI workflow additions for testing and linting.

**Triage**: P2 CI/CD. Delegating to @devops. CI workflow additions for testing and linting.
AI-Manager commented 2026-03-28 11:03:47 +00:00
Author
Owner
Copy Link
Copy Source

Status: Already Implemented. After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.

**Status: Already Implemented.** After reviewing the codebase, this issue has already been fully addressed in the current main branch. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?