leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-dev environments #611

New Issue
Closed
opened 2026-03-28 11:21:20 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 11:21:20 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships a fallback secret sparc-secret-key-change-in-production used when JWT_SECRET is unset. If this secret reaches production, all tokens issued can be forged by anyone who reads the source code.

Roadmap item: P1 > Security hardening

What to do

  • Add a startup check (e.g., in main.py lifespan or an __init__ guard) that reads the active JWT secret.
  • If the secret equals the known default value AND the environment is not development (check an APP_ENV or ENVIRONMENT variable), raise a RuntimeError or log a CRITICAL message and sys.exit(1).
  • Document the required JWT_SECRET env var in README.md and .env.example.

Acceptance criteria

  • Starting the API with the default secret and APP_ENV=production exits with a clear error message.
  • Starting with APP_ENV=development (or unset) still works with the default secret for local dev.
  • A unit test confirms the startup check raises as expected.
## Context `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` used when `JWT_SECRET` is unset. If this secret reaches production, all tokens issued can be forged by anyone who reads the source code. Roadmap item: P1 > Security hardening ## What to do - Add a startup check (e.g., in `main.py` lifespan or an `__init__` guard) that reads the active JWT secret. - If the secret equals the known default value AND the environment is not `development` (check an `APP_ENV` or `ENVIRONMENT` variable), raise a `RuntimeError` or log a `CRITICAL` message and `sys.exit(1)`. - Document the required `JWT_SECRET` env var in `README.md` and `.env.example`. ## Acceptance criteria - [ ] Starting the API with the default secret and `APP_ENV=production` exits with a clear error message. - [ ] Starting with `APP_ENV=development` (or unset) still works with the default secret for local dev. - [ ] A unit test confirms the startup check raises as expected.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 11:21:20 +00:00
AI-Manager commented 2026-03-28 12:04:20 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. check_jwt_secret() in auth.py refuses startup with the default JWT secret when APP_ENV is not development. The app_env config is in config.py and .env.example documents the variable.

Closing: already implemented on main. `check_jwt_secret()` in `auth.py` refuses startup with the default JWT secret when `APP_ENV` is not `development`. The `app_env` config is in `config.py` and `.env.example` documents the variable.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?