leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #612

New Issue
Closed
opened 2026-03-28 11:21:25 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 11:21:25 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes http://localhost:3000 and http://localhost:5173 as CORS allowed origins. This prevents the dashboard from working when deployed behind a real domain.

Roadmap item: P1 > Security hardening

What to do

  • Read a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins) in config.py.
  • Fall back to the current localhost defaults when the variable is unset (keeps local dev working).
  • Pass the resolved list to the CORSMiddleware in api.py.
  • Add CORS_ALLOWED_ORIGINS to .env.example with a comment.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Omitting the variable still allows localhost:3000 and localhost:5173.
  • The value is sourced from config.py, not inline in api.py.
## Context `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as CORS allowed origins. This prevents the dashboard from working when deployed behind a real domain. Roadmap item: P1 > Security hardening ## What to do - Read a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins) in `config.py`. - Fall back to the current localhost defaults when the variable is unset (keeps local dev working). - Pass the resolved list to the `CORSMiddleware` in `api.py`. - Add `CORS_ALLOWED_ORIGINS` to `.env.example` with a comment. ## Acceptance criteria - [ ] Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin. - [ ] Omitting the variable still allows `localhost:3000` and `localhost:5173`. - [ ] The value is sourced from `config.py`, not inline in `api.py`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 11:21:25 +00:00
AI-Manager commented 2026-03-28 12:04:21 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. config.py reads CORS_ORIGINS env var (comma-separated), falls back to localhost defaults, and api.py uses config.cors_origins in CORSMiddleware. docker-compose.yml also exposes the variable.

Closing: already implemented on main. `config.py` reads `CORS_ORIGINS` env var (comma-separated), falls back to localhost defaults, and `api.py` uses `config.cors_origins` in `CORSMiddleware`. `docker-compose.yml` also exposes the variable.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#612
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?