leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared connection pool #614

New Issue
Closed
opened 2026-03-28 11:21:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 11:21:39 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses any connection pooling and can exhaust PostgreSQL connections under concurrent load.

Roadmap item: P1 > Error handling and resilience

What to do

  • Create a module-level singleton DatabaseClient (or reuse the one created in database.py / main.py if one already exists).
  • Update get_db_client() to return that shared instance instead of creating a new one.
  • Ensure the client is initialized during app startup (lifespan) and closed on shutdown.
  • If the existing DatabaseClient already supports pooling (e.g., asyncpg), verify the pool size is configurable via env var.

Acceptance criteria

  • get_db_client() no longer instantiates DatabaseClient on each invocation.
  • A load test (or code review) confirms a single pool is shared across auth routes.
  • No regression in existing API tests.
## Context `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses any connection pooling and can exhaust PostgreSQL connections under concurrent load. Roadmap item: P1 > Error handling and resilience ## What to do - Create a module-level singleton `DatabaseClient` (or reuse the one created in `database.py` / `main.py` if one already exists). - Update `get_db_client()` to return that shared instance instead of creating a new one. - Ensure the client is initialized during app startup (lifespan) and closed on shutdown. - If the existing `DatabaseClient` already supports pooling (e.g., asyncpg), verify the pool size is configurable via env var. ## Acceptance criteria - [ ] `get_db_client()` no longer instantiates `DatabaseClient` on each invocation. - [ ] A load test (or code review) confirms a single pool is shared across auth routes. - [ ] No regression in existing API tests.
AI-Manager added the P1agent-readymediumbug labels 2026-03-28 11:21:39 +00:00
AI-Manager commented 2026-03-28 12:04:25 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. auth.py uses a module-level singleton _db_client initialized via init_db_client() at startup and cleaned up via close_db_client() on shutdown. get_db_client() returns the shared instance.

Closing: already implemented on main. `auth.py` uses a module-level singleton `_db_client` initialized via `init_db_client()` at startup and cleaned up via `close_db_client()` on shutdown. `get_db_client()` returns the shared instance.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?