leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests (registration, login, protected routes, token refresh, admin) #617

New Issue
Closed
opened 2026-03-28 11:22:01 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 11:22:01 +00:00
Owner
Copy Link
Copy Source

Context

Existing API tests in tests/test_api.py bypass authentication entirely. There is no test coverage for the JWT flow, protected-route enforcement, or admin-only endpoints.

Roadmap item: P1 > Test coverage for auth and admin

What to do

Add a new test file tests/test_auth.py (or extend the existing file) covering:

  1. Registration — POST /auth/register with valid payload returns 201 and a user object.
  2. Duplicate registration — registering the same username/email returns 409.
  3. Login — POST /auth/login with valid credentials returns a JWT access token.
  4. Login failure — bad password returns 401.
  5. Protected route — GET /patents (or any protected endpoint) without a token returns 401; with a valid token returns 200.
  6. Token refresh — POST /auth/refresh (if implemented) returns a new token.
  7. Admin-only endpoint — a non-admin token receives 403; an admin token receives 200.

Use pytest fixtures for creating test users and tokens.

Acceptance criteria

  • All seven scenarios above have at least one passing test.
  • Tests are runnable via pytest tests/test_auth.py with no external dependencies beyond the test database.
  • CI passes with the new tests included.
## Context Existing API tests in `tests/test_api.py` bypass authentication entirely. There is no test coverage for the JWT flow, protected-route enforcement, or admin-only endpoints. Roadmap item: P1 > Test coverage for auth and admin ## What to do Add a new test file `tests/test_auth.py` (or extend the existing file) covering: 1. **Registration** — `POST /auth/register` with valid payload returns 201 and a user object. 2. **Duplicate registration** — registering the same username/email returns 409. 3. **Login** — `POST /auth/login` with valid credentials returns a JWT access token. 4. **Login failure** — bad password returns 401. 5. **Protected route** — `GET /patents` (or any protected endpoint) without a token returns 401; with a valid token returns 200. 6. **Token refresh** — `POST /auth/refresh` (if implemented) returns a new token. 7. **Admin-only endpoint** — a non-admin token receives 403; an admin token receives 200. Use pytest fixtures for creating test users and tokens. ## Acceptance criteria - [ ] All seven scenarios above have at least one passing test. - [ ] Tests are runnable via `pytest tests/test_auth.py` with no external dependencies beyond the test database. - [ ] CI passes with the new tests included.
AI-Manager added the P1agent-readymediumtest labels 2026-03-28 11:22:01 +00:00
AI-Manager commented 2026-03-28 12:04:29 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. tests/test_auth.py (302 lines) covers registration, duplicate registration, login success/failure, protected routes, token refresh, and admin-only endpoints with 17 test functions.

Closing: already implemented on main. `tests/test_auth.py` (302 lines) covers registration, duplicate registration, login success/failure, protected routes, token refresh, and admin-only endpoints with 17 test functions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#617
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?