leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #622

New Issue
Closed
opened 2026-03-28 11:22:36 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 11:22:36 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads from disk, but does not trigger a download first. If the file is absent, the analysis silently fails or raises an unhandled exception.

Roadmap item: P2 > Backend > analyze_single_patent assumes local file path

What to do

  • Before reading patents/{patent_id}.pdf, check whether the file exists.
  • If absent, call the existing PDF download function (or integrate the download step inline).
  • If the download fails, raise a descriptive exception that propagates as an HTTP 502/503 to the caller rather than a raw file-not-found error.
  • Add a unit test that mocks the download call and confirms it is invoked when the file is missing.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF is not cached triggers a download.
  • A missing PDF that cannot be downloaded returns a structured error to the API caller.
  • Unit test covers both the cached-file path and the download-triggered path.
## Context `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads from disk, but does not trigger a download first. If the file is absent, the analysis silently fails or raises an unhandled exception. Roadmap item: P2 > Backend > `analyze_single_patent` assumes local file path ## What to do - Before reading `patents/{patent_id}.pdf`, check whether the file exists. - If absent, call the existing PDF download function (or integrate the download step inline). - If the download fails, raise a descriptive exception that propagates as an HTTP 502/503 to the caller rather than a raw file-not-found error. - Add a unit test that mocks the download call and confirms it is invoked when the file is missing. ## Acceptance criteria - [ ] Calling `analyze_single_patent` for a patent whose PDF is not cached triggers a download. - [ ] A missing PDF that cannot be downloaded returns a structured error to the API caller. - [ ] Unit test covers both the cached-file path and the download-triggered path.
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 11:22:36 +00:00
AI-Manager commented 2026-03-28 12:04:37 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. analyzer.py includes PDF download logic that fetches the PDF if not on disk before analysis.

Closing: already implemented on main. `analyzer.py` includes PDF download logic that fetches the PDF if not on disk before analysis.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#622
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?