leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #628

New Issue
Closed
opened 2026-03-28 11:23:16 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 11:23:16 +00:00
Owner
Copy Link
Copy Source

Context

There is no linting or type checking in the CI pipeline. Style violations and type errors accumulate silently.

Roadmap item: P2 > CI/CD > No linting or type checking

What to do

  • Add a lint job to .gitea/workflows/build.yaml.
  • For Python: install ruff and run ruff check . from the backend directory. Add a ruff.toml or [tool.ruff] section in pyproject.toml if not present, with sensible defaults.
  • For TypeScript: run tsc --noEmit from the frontend directory. Ensure tsconfig.json is strict enough to catch real errors.
  • Both checks should be required before the build job proceeds.
  • Fix any pre-existing lint/type errors found by the new checks.

Acceptance criteria

  • ruff check . passes on the backend with zero errors.
  • tsc --noEmit passes on the frontend with zero errors.
  • Both run in CI and block the build on failure.
## Context There is no linting or type checking in the CI pipeline. Style violations and type errors accumulate silently. Roadmap item: P2 > CI/CD > No linting or type checking ## What to do - Add a `lint` job to `.gitea/workflows/build.yaml`. - For Python: install `ruff` and run `ruff check .` from the backend directory. Add a `ruff.toml` or `[tool.ruff]` section in `pyproject.toml` if not present, with sensible defaults. - For TypeScript: run `tsc --noEmit` from the frontend directory. Ensure `tsconfig.json` is strict enough to catch real errors. - Both checks should be required before the build job proceeds. - Fix any pre-existing lint/type errors found by the new checks. ## Acceptance criteria - [ ] `ruff check .` passes on the backend with zero errors. - [ ] `tsc --noEmit` passes on the frontend with zero errors. - [ ] Both run in CI and block the build on failure.
AI-Manager added the P2agent-readymediuminfra labels 2026-03-28 11:23:16 +00:00
AI-Manager commented 2026-03-28 12:04:48 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. .gitea/workflows/test.yaml includes both ruff check SPARC/ tests/ and npx tsc --noEmit steps.

Closing: already implemented on main. `.gitea/workflows/test.yaml` includes both `ruff check SPARC/ tests/` and `npx tsc --noEmit` steps.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?