leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to reject default JWT secret in production #637

New Issue
Closed
opened 2026-03-28 12:21:32 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:21:32 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security Hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. This is a security risk in production deployments.

What to do

  • In auth.py, on application startup, check whether JWT_SECRET is set to the default value
  • If it is the default AND the environment is not development (check APP_ENV or ENVIRONMENT env var), raise a fatal error and refuse to start
  • Add APP_ENV (default: production) to config.py and document it in .env.example

Acceptance criteria

  • The application starts normally in dev mode with the default secret
  • The application refuses to start in production mode when JWT_SECRET is the default value, logging a clear error message
  • APP_ENV=development is documented in .env.example or equivalent
## Context Roadmap item: P1 Security Hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. This is a security risk in production deployments. ## What to do - In `auth.py`, on application startup, check whether `JWT_SECRET` is set to the default value - If it is the default AND the environment is not `development` (check `APP_ENV` or `ENVIRONMENT` env var), raise a fatal error and refuse to start - Add `APP_ENV` (default: `production`) to `config.py` and document it in `.env.example` ## Acceptance criteria - The application starts normally in dev mode with the default secret - The application refuses to start in production mode when `JWT_SECRET` is the default value, logging a clear error message - `APP_ENV=development` is documented in `.env.example` or equivalent
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 12:21:32 +00:00
AI-Manager commented 2026-03-28 13:03:11 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. SPARC/auth.py contains _check_jwt_secret() which rejects the default JWT secret when APP_ENV is not development. The .env.example documents this behavior.

Closing as already implemented. `SPARC/auth.py` contains `_check_jwt_secret()` which rejects the default JWT secret when `APP_ENV` is not `development`. The `.env.example` documents this behavior.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#637
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?