leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #638

New Issue
Closed
opened 2026-03-28 12:21:41 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:21:41 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security Hardening

api.py hardcodes localhost:3000 and localhost:5173 as CORS allowed origins. This means the dashboard breaks when deployed behind a real domain.

What to do

  • In api.py, replace the hardcoded origins list with a value read from a CORS_ALLOWED_ORIGINS environment variable
  • The variable should accept a comma-separated list of origins (e.g. https://sparc.example.com,https://admin.example.com)
  • Default to http://localhost:3000,http://localhost:5173 for backwards-compatible local development
  • Update config.py to expose this setting
  • Document CORS_ALLOWED_ORIGINS in .env.example

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://my.domain.com causes the API to accept requests from that origin
  • Unset variable falls back to localhost defaults
  • The parsing is robust (strips whitespace, handles empty values gracefully)
## Context Roadmap item: P1 Security Hardening `api.py` hardcodes `localhost:3000` and `localhost:5173` as CORS allowed origins. This means the dashboard breaks when deployed behind a real domain. ## What to do - In `api.py`, replace the hardcoded origins list with a value read from a `CORS_ALLOWED_ORIGINS` environment variable - The variable should accept a comma-separated list of origins (e.g. `https://sparc.example.com,https://admin.example.com`) - Default to `http://localhost:3000,http://localhost:5173` for backwards-compatible local development - Update `config.py` to expose this setting - Document `CORS_ALLOWED_ORIGINS` in `.env.example` ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://my.domain.com` causes the API to accept requests from that origin - Unset variable falls back to localhost defaults - The parsing is robust (strips whitespace, handles empty values gracefully)
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 12:21:41 +00:00
AI-Manager commented 2026-03-28 13:03:12 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. SPARC/config.py reads CORS_ORIGINS from the environment (comma-separated list) and api.py passes config.cors_origins to the CORS middleware. Documented in .env.example.

Closing as already implemented. `SPARC/config.py` reads `CORS_ORIGINS` from the environment (comma-separated list) and `api.py` passes `config.cors_origins` to the CORS middleware. Documented in `.env.example`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#638
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?