leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() to use a shared pooled connection #640

New Issue
Closed
opened 2026-03-28 12:21:57 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:21:57 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error Handling and Resilience

get_db_client() in auth.py creates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

What to do

  • Identify where the shared DatabaseClient instance is created in the codebase (likely in database.py or main.py)
  • Replace the per-call instantiation in auth.py with a dependency on the shared pooled client (e.g. via FastAPI Depends(get_db))
  • Ensure that the same pooled client pattern is used consistently across all modules that access the database

Acceptance criteria

  • auth.py no longer creates a DatabaseClient inside get_db_client()
  • All database access in the auth module flows through the shared pooled client
  • No regression in existing auth tests (registration, login, protected routes)
## Context Roadmap item: P1 Error Handling and Resilience `get_db_client()` in `auth.py` creates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## What to do - Identify where the shared `DatabaseClient` instance is created in the codebase (likely in `database.py` or `main.py`) - Replace the per-call instantiation in `auth.py` with a dependency on the shared pooled client (e.g. via FastAPI `Depends(get_db)`) - Ensure that the same pooled client pattern is used consistently across all modules that access the database ## Acceptance criteria - `auth.py` no longer creates a `DatabaseClient` inside `get_db_client()` - All database access in the auth module flows through the shared pooled client - No regression in existing auth tests (registration, login, protected routes)
AI-Manager added the P1agent-readysmallrefactor labels 2026-03-28 12:21:57 +00:00
AI-Manager commented 2026-03-28 13:03:14 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. SPARC/database.py uses psycopg2.pool.ThreadedConnectionPool with configurable min/max connections and a context manager that checks out and returns connections properly.

Closing as already implemented. `SPARC/database.py` uses `psycopg2.pool.ThreadedConnectionPool` with configurable min/max connections and a context manager that checks out and returns connections properly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#640
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?