leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #642

New Issue
Closed
opened 2026-03-28 12:22:18 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:22:18 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error Handling and Resilience

/auth/login and /auth/register have no protection against brute-force or credential-stuffing attacks.

What to do

  • Add rate limiting middleware to the FastAPI app (e.g. slowapi or a custom starlette middleware)
  • Apply a sensible limit to the auth endpoints: e.g. 10 requests per minute per IP for login, 5 per minute per IP for registration
  • Return HTTP 429 with a Retry-After header when the limit is exceeded
  • Document the rate limit thresholds in config.py or as environment variables so they can be adjusted without code changes

Acceptance criteria

  • Exceeding the login rate limit returns 429
  • Exceeding the registration rate limit returns 429
  • Normal usage (under the limit) is unaffected
  • Thresholds are configurable via environment variables
## Context Roadmap item: P1 Error Handling and Resilience `/auth/login` and `/auth/register` have no protection against brute-force or credential-stuffing attacks. ## What to do - Add rate limiting middleware to the FastAPI app (e.g. `slowapi` or a custom `starlette` middleware) - Apply a sensible limit to the auth endpoints: e.g. 10 requests per minute per IP for login, 5 per minute per IP for registration - Return HTTP 429 with a `Retry-After` header when the limit is exceeded - Document the rate limit thresholds in `config.py` or as environment variables so they can be adjusted without code changes ## Acceptance criteria - Exceeding the login rate limit returns 429 - Exceeding the registration rate limit returns 429 - Normal usage (under the limit) is unaffected - Thresholds are configurable via environment variables
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 12:22:18 +00:00
AI-Manager commented 2026-03-28 13:03:18 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. SPARC/api.py uses slowapi with @limiter.limit() decorators on /auth/register (5/min) and /auth/login (10/min). A custom 429 handler returns proper error responses.

Closing as already implemented. `SPARC/api.py` uses `slowapi` with `@limiter.limit()` decorators on `/auth/register` (5/min) and `/auth/login` (10/min). A custom 429 handler returns proper error responses.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?