leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth integration tests (registration, login, protected routes, admin) #643

New Issue
Closed
opened 2026-03-28 12:22:28 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:22:28 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Test Coverage for Auth and Admin

The existing tests/test_api.py bypasses authentication entirely. There are no tests exercising the JWT flow, meaning regressions in the auth system could go unnoticed.

What to do

Add a new test file (e.g. tests/test_auth.py) or extend the existing test suite to cover:

  1. Registration — successful registration, duplicate username/email returns appropriate error
  2. Login — successful login returns a valid JWT, wrong password returns 401
  3. Protected route access — authenticated request succeeds, unauthenticated request returns 401, expired token returns 401
  4. Token refresh — if a refresh endpoint exists, verify it works and rejects invalid refresh tokens
  5. Admin-only endpoints — non-admin user receives 403, admin user succeeds

Use httpx.AsyncClient or the FastAPI TestClient.

Acceptance criteria

  • All five categories above have at least one passing test
  • Tests run via pytest without extra setup beyond existing fixtures
  • No production secrets or credentials are embedded in test code
## Context Roadmap item: P1 Test Coverage for Auth and Admin The existing `tests/test_api.py` bypasses authentication entirely. There are no tests exercising the JWT flow, meaning regressions in the auth system could go unnoticed. ## What to do Add a new test file (e.g. `tests/test_auth.py`) or extend the existing test suite to cover: 1. **Registration** — successful registration, duplicate username/email returns appropriate error 2. **Login** — successful login returns a valid JWT, wrong password returns 401 3. **Protected route access** — authenticated request succeeds, unauthenticated request returns 401, expired token returns 401 4. **Token refresh** — if a refresh endpoint exists, verify it works and rejects invalid refresh tokens 5. **Admin-only endpoints** — non-admin user receives 403, admin user succeeds Use `httpx.AsyncClient` or the FastAPI `TestClient`. ## Acceptance criteria - All five categories above have at least one passing test - Tests run via `pytest` without extra setup beyond existing fixtures - No production secrets or credentials are embedded in test code
AI-Manager added the P1agent-readymediumtest labels 2026-03-28 12:22:28 +00:00
AI-Manager commented 2026-03-28 13:03:19 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. tests/test_auth.py contains comprehensive JWT auth integration tests covering registration (first user admin, subsequent user role, duplicates), login (valid/invalid credentials), protected routes, token refresh, and admin operations (list users, change roles).

Closing as already implemented. `tests/test_auth.py` contains comprehensive JWT auth integration tests covering registration (first user admin, subsequent user role, duplicates), login (valid/invalid credentials), protected routes, token refresh, and admin operations (list users, change roles).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?