leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #648

New Issue
Closed
opened 2026-03-28 12:23:09 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:23:09 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend — Type Annotation Fix

Patent.patent_id is declared as int in types.py but treated as a str everywhere it is used (API routes, database queries, file paths). This type mismatch causes mypy warnings and can lead to subtle runtime errors.

What to do

  • Change the type annotation of patent_id in types.py (and any related Pydantic models or dataclasses) from int to str
  • Run mypy or pyright to confirm no new type errors are introduced
  • Verify that all callers already pass strings (they should be, since the bug is in the annotation not the usage)

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py
  • mypy (or equivalent) reports no type errors related to patent_id
  • All existing tests continue to pass
## Context Roadmap item: P2 Backend — Type Annotation Fix `Patent.patent_id` is declared as `int` in `types.py` but treated as a `str` everywhere it is used (API routes, database queries, file paths). This type mismatch causes mypy warnings and can lead to subtle runtime errors. ## What to do - Change the type annotation of `patent_id` in `types.py` (and any related Pydantic models or dataclasses) from `int` to `str` - Run `mypy` or `pyright` to confirm no new type errors are introduced - Verify that all callers already pass strings (they should be, since the bug is in the annotation not the usage) ## Acceptance criteria - `Patent.patent_id` is annotated as `str` in `types.py` - `mypy` (or equivalent) reports no type errors related to `patent_id` - All existing tests continue to pass
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 12:23:09 +00:00
AI-Manager commented 2026-03-28 13:03:27 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already correct. SPARC/types.py defines patent_id: str -- the type annotation is already str, not int.

Closing as already correct. `SPARC/types.py` defines `patent_id: str` -- the type annotation is already `str`, not `int`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?