forked from 0xWheatyz/SPARC
Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) #650
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Roadmap item: P2 Frontend — Reproducible Builds
The frontend repository has no lockfile committed. This means
npm install(or equivalent) resolves to different dependency versions on different machines and in CI, leading to non-reproducible builds.What to do
npm installgeneratespackage-lock.json,pnpm installgeneratespnpm-lock.yamlnpm ci(orpnpm install --frozen-lockfile) instead ofnpm installto enforce the lockfileAcceptance criteria
package-lock.jsonorpnpm-lock.yaml) is present at the frontend root and committed to gitnpm ci(or equivalent) succeeds from a clean checkoutClosing as already present.
frontend/package-lock.jsonexists in the repository and is used bynpm ciin the CI workflow.