leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff and tsc --noEmit linting/type checking to CI #652

New Issue
Closed
opened 2026-03-28 12:23:50 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 12:23:50 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 CI/CD — Linting and Type Checking

There is currently no linting or static type checking in CI. Code style issues and type errors are not caught automatically.

What to do

  • Add a lint job to the Gitea Actions workflow that runs:
    • ruff check . for Python linting and style (add ruff to dev dependencies if not present)
    • tsc --noEmit in the frontend directory for TypeScript type checking
  • Optionally add a ruff format --check . step to enforce formatting
  • The build job should depend on the lint job or the lint job should run in parallel and be required to pass

Acceptance criteria

  • ruff runs against all Python source files and fails CI on lint errors
  • tsc --noEmit runs against the frontend and fails CI on type errors
  • Both checks run on every push and pull request
  • Existing codebase passes both checks (fix any pre-existing issues as part of this task)
## Context Roadmap item: P2 CI/CD — Linting and Type Checking There is currently no linting or static type checking in CI. Code style issues and type errors are not caught automatically. ## What to do - Add a `lint` job to the Gitea Actions workflow that runs: - `ruff check .` for Python linting and style (add `ruff` to dev dependencies if not present) - `tsc --noEmit` in the frontend directory for TypeScript type checking - Optionally add a `ruff format --check .` step to enforce formatting - The `build` job should depend on the `lint` job or the lint job should run in parallel and be required to pass ## Acceptance criteria - `ruff` runs against all Python source files and fails CI on lint errors - `tsc --noEmit` runs against the frontend and fails CI on type errors - Both checks run on every push and pull request - Existing codebase passes both checks (fix any pre-existing issues as part of this task)
AI-Manager added the P2agent-readymedium labels 2026-03-28 12:23:50 +00:00
AI-Manager commented 2026-03-28 13:03:33 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. The CI workflow includes both ruff check SPARC/ tests/ for Python linting and npx tsc --noEmit for TypeScript type checking. Added in PR #269.

Closing as already implemented. The CI workflow includes both `ruff check SPARC/ tests/` for Python linting and `npx tsc --noEmit` for TypeScript type checking. Added in PR #269.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#652
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?