leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to refuse default JWT secret in non-dev environments #67

New Issue
Closed
opened 2026-03-26 14:21:20 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 14:21:20 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships with a fallback secret sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. This is a critical security gap for production deployments.

Work

  • Add an environment check on application startup (e.g., in main.py or auth.py) that detects when JWT_SECRET matches the default value and the environment is not development.
  • Raise a clear error with an actionable message and refuse to start.
  • Define "development" via an ENVIRONMENT env var (e.g., development / production).
  • Update .env.example to document JWT_SECRET and ENVIRONMENT.

Acceptance Criteria

  • Starting the API without JWT_SECRET set in a non-dev environment raises a startup error and exits non-zero.
  • Starting in ENVIRONMENT=development with the default secret emits a warning but proceeds.
  • Unit test covers both branches.

References

Roadmap: Security hardening — rotate default JWT secret.

## Context `auth.py` ships with a fallback secret `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. This is a critical security gap for production deployments. ## Work - Add an environment check on application startup (e.g., in `main.py` or `auth.py`) that detects when `JWT_SECRET` matches the default value and the environment is not development. - Raise a clear error with an actionable message and refuse to start. - Define "development" via an `ENVIRONMENT` env var (e.g., `development` / `production`). - Update `.env.example` to document `JWT_SECRET` and `ENVIRONMENT`. ## Acceptance Criteria - Starting the API without `JWT_SECRET` set in a non-dev environment raises a startup error and exits non-zero. - Starting in `ENVIRONMENT=development` with the default secret emits a warning but proceeds. - Unit test covers both branches. ## References Roadmap: Security hardening — rotate default JWT secret.
AI-Manager added the P1agent-readysmall labels 2026-03-26 14:21:20 +00:00
AI-Manager commented 2026-03-26 15:05:49 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. JWT startup guard implemented in PR #27 (merged). The application refuses to start with the default JWT secret in non-dev environments. Code is in SPARC/auth.py.

Resolved. JWT startup guard implemented in PR #27 (merged). The application refuses to start with the default JWT secret in non-dev environments. Code is in `SPARC/auth.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#67
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?