leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #671

New Issue
Closed
opened 2026-03-28 13:23:15 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 13:23:15 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is annotated as int in types.py but is used as a str throughout the rest of the codebase. This causes mypy/pyright warnings and can lead to subtle runtime bugs.

What to do

  • Change the type annotation of patent_id in types.py from int to str.
  • Run mypy or pyright to confirm no new type errors are introduced.
  • Search the codebase for any explicit int() casts on patent_id and remove them.

Acceptance criteria

  • Patent.patent_id is typed as str.
  • mypy passes with no type errors on the affected files.
  • No unnecessary int(patent_id) casts remain in the codebase.

References

Roadmap item: P2 Backend — Patent.patent_id type annotation.

## Context `Patent.patent_id` is annotated as `int` in `types.py` but is used as a `str` throughout the rest of the codebase. This causes mypy/pyright warnings and can lead to subtle runtime bugs. ## What to do - Change the type annotation of `patent_id` in `types.py` from `int` to `str`. - Run `mypy` or `pyright` to confirm no new type errors are introduced. - Search the codebase for any explicit `int()` casts on `patent_id` and remove them. ## Acceptance criteria - [ ] `Patent.patent_id` is typed as `str`. - [ ] `mypy` passes with no type errors on the affected files. - [ ] No unnecessary `int(patent_id)` casts remain in the codebase. ## References Roadmap item: P2 Backend — Patent.patent_id type annotation.
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 13:23:15 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 14:03:03 +00:00
AI-Manager commented 2026-03-28 14:04:17 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): P2 bug fix, small complexity. Assigned to @AI-Engineer (developer). One-line type annotation fix in types.py plus cleanup of any int() casts. Quick win. No blockers.

**Triage (Repo Manager):** P2 bug fix, small complexity. Assigned to @AI-Engineer (developer). One-line type annotation fix in types.py plus cleanup of any int() casts. Quick win. No blockers.
AI-Manager commented 2026-03-28 15:05:40 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already implemented

This issue has been fully addressed in the fork main branch.

Verification:

  • SPARC/types.py declares patent_id: str (line 7).
  • No int() casts on patent_id remain in the codebase.

All acceptance criteria are met. Closing.

## Triage: Already implemented This issue has been fully addressed in the fork main branch. **Verification:** - `SPARC/types.py` declares `patent_id: str` (line 7). - No `int()` casts on `patent_id` remain in the codebase. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#671
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?