leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #673

New Issue
Closed
opened 2026-03-28 13:23:33 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 13:23:33 +00:00
Owner
Copy Link
Copy Source

Context

The frontend directory has no lockfile committed to the repository. Without a lockfile, npm install / pnpm install resolves dependencies non-deterministically, meaning CI builds and local development may use different package versions.

What to do

  • Decide on a package manager (npm or pnpm) and generate the corresponding lockfile.
  • Commit the lockfile to the repository.
  • Update the CI workflow to use npm ci (or pnpm install --frozen-lockfile) so it fails if the lockfile is out of date.
  • Add a note to the developer setup docs about not running plain npm install without updating the lockfile.

Acceptance criteria

  • package-lock.json or pnpm-lock.yaml is present and committed.
  • CI uses the frozen-lockfile install command.
  • npm ci (or equivalent) exits 0 in CI.

References

Roadmap item: P2 Frontend — missing lockfile.

## Context The frontend directory has no lockfile committed to the repository. Without a lockfile, `npm install` / `pnpm install` resolves dependencies non-deterministically, meaning CI builds and local development may use different package versions. ## What to do - Decide on a package manager (npm or pnpm) and generate the corresponding lockfile. - Commit the lockfile to the repository. - Update the CI workflow to use `npm ci` (or `pnpm install --frozen-lockfile`) so it fails if the lockfile is out of date. - Add a note to the developer setup docs about not running plain `npm install` without updating the lockfile. ## Acceptance criteria - [ ] `package-lock.json` or `pnpm-lock.yaml` is present and committed. - [ ] CI uses the frozen-lockfile install command. - [ ] `npm ci` (or equivalent) exits 0 in CI. ## References Roadmap item: P2 Frontend — missing lockfile.
AI-Manager added the P2agent-readysmallinfra labels 2026-03-28 13:23:33 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 14:03:04 +00:00
AI-Manager commented 2026-03-28 15:05:46 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already implemented

This issue has been fully addressed in the fork main branch.

Verification:

  • frontend/package-lock.json is present and committed.
  • CI workflow (test.yaml) uses npm ci for frozen-lockfile installs (line 41).

All acceptance criteria are met. Closing.

## Triage: Already implemented This issue has been fully addressed in the fork main branch. **Verification:** - `frontend/package-lock.json` is present and committed. - CI workflow (`test.yaml`) uses `npm ci` for frozen-lockfile installs (line 41). All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?