leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #675

New Issue
Closed
opened 2026-03-28 13:23:49 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 13:23:49 +00:00
Owner
Copy Link
Copy Source

Context

There is no linting or static type checking in CI. Style regressions and type errors can be introduced undetected.

What to do

  • Add a lint job (or extend the test job) that runs:
    • ruff check . on the Python backend.
    • tsc --noEmit on the TypeScript frontend.
  • Fix any pre-existing lint or type errors uncovered by these tools.
  • Ensure the lint job runs on every push and pull request.
  • Optionally add ruff format --check to enforce consistent formatting.

Acceptance criteria

  • ruff check . exits 0 with no errors in CI.
  • tsc --noEmit exits 0 with no type errors in CI.
  • The lint job blocks the build if errors are found.
  • All pre-existing lint/type issues are resolved.

References

Roadmap item: P2 CI/CD — no linting or type checking.

## Context There is no linting or static type checking in CI. Style regressions and type errors can be introduced undetected. ## What to do - Add a `lint` job (or extend the `test` job) that runs: - `ruff check .` on the Python backend. - `tsc --noEmit` on the TypeScript frontend. - Fix any pre-existing lint or type errors uncovered by these tools. - Ensure the `lint` job runs on every push and pull request. - Optionally add `ruff format --check` to enforce consistent formatting. ## Acceptance criteria - [ ] `ruff check .` exits 0 with no errors in CI. - [ ] `tsc --noEmit` exits 0 with no type errors in CI. - [ ] The lint job blocks the build if errors are found. - [ ] All pre-existing lint/type issues are resolved. ## References Roadmap item: P2 CI/CD — no linting or type checking.
AI-Manager added the P2agent-readymediuminfra labels 2026-03-28 13:23:49 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 14:03:05 +00:00
AI-Manager commented 2026-03-28 15:05:53 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already implemented

This issue has been fully addressed in the fork main branch.

Verification:

  • .gitea/workflows/test.yaml runs ruff check SPARC/ tests/ (line 35) and tsc --noEmit (line 56).
  • Both lint/type-check steps run on every push and PR.
  • The workflow gates the build on these checks passing.

All acceptance criteria are met. Closing.

## Triage: Already implemented This issue has been fully addressed in the fork main branch. **Verification:** - `.gitea/workflows/test.yaml` runs `ruff check SPARC/ tests/` (line 35) and `tsc --noEmit` (line 56). - Both lint/type-check steps run on every push and PR. - The workflow gates the build on these checks passing. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?