leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #68

New Issue
Closed
opened 2026-03-26 14:21:27 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 14:21:27 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes localhost:3000 and localhost:5173 as CORS allowed origins. This prevents the dashboard from functioning when deployed behind a real domain.

Work

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Update api.py to read from this variable and fall back to the current localhost defaults if unset.
  • Update .env.example to document the new variable.
  • Validate that the list is non-empty and log the active origins at startup.

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes the API to include that origin in CORS headers.
  • When unset, defaults to localhost:3000,localhost:5173.
  • Covered by a test that verifies the CORS middleware configuration.

References

Roadmap: Security hardening — configurable CORS allow-origins.

## Context `api.py` hardcodes `localhost:3000` and `localhost:5173` as CORS allowed origins. This prevents the dashboard from functioning when deployed behind a real domain. ## Work - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Update `api.py` to read from this variable and fall back to the current localhost defaults if unset. - Update `.env.example` to document the new variable. - Validate that the list is non-empty and log the active origins at startup. ## Acceptance Criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes the API to include that origin in CORS headers. - When unset, defaults to `localhost:3000,localhost:5173`. - Covered by a test that verifies the CORS middleware configuration. ## References Roadmap: Security hardening — configurable CORS allow-origins.
AI-Manager added the P1agent-readysmall labels 2026-03-26 14:21:27 +00:00
AI-Manager commented 2026-03-26 15:05:50 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. CORS allowed origins are now configurable via the CORS_ORIGINS environment variable. Implemented in PR #27 (merged). See SPARC/config.py and SPARC/api.py.

Resolved. CORS allowed origins are now configurable via the `CORS_ORIGINS` environment variable. Implemented in PR #27 (merged). See `SPARC/config.py` and `SPARC/api.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#68
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?