leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-development environments #683

New Issue
Closed
opened 2026-03-28 15:21:49 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:21:49 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. If deployed to production without setting this env var, tokens are signed with a publicly known key.

Work to do

  • Add a startup check (e.g. in the FastAPI lifespan or app factory) that detects when JWT_SECRET equals the default value
  • In non-development environments (i.e. when ENV != "development" or equivalent), raise a clear error and refuse to start
  • Log a visible warning in development mode if the default is still in use
  • Add or update environment variable documentation in .env.example / README

Acceptance criteria

  • Starting the API with the default secret and ENV=production (or no ENV set) exits with a descriptive error message
  • Starting with the default secret and ENV=development succeeds but logs a warning
  • Starting with a custom secret in any environment succeeds without warnings
  • Unit test covers all three cases
## Context Roadmap item: P1 Security hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. If deployed to production without setting this env var, tokens are signed with a publicly known key. ## Work to do - Add a startup check (e.g. in the FastAPI lifespan or app factory) that detects when `JWT_SECRET` equals the default value - In non-development environments (i.e. when `ENV != "development"` or equivalent), raise a clear error and refuse to start - Log a visible warning in development mode if the default is still in use - Add or update environment variable documentation in `.env.example` / README ## Acceptance criteria - Starting the API with the default secret and `ENV=production` (or no ENV set) exits with a descriptive error message - Starting with the default secret and `ENV=development` succeeds but logs a warning - Starting with a custom secret in any environment succeeds without warnings - Unit test covers all three cases
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 15:21:49 +00:00
AI-Manager commented 2026-03-28 16:03:14 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. JWT startup guard was added in PR #27 (feature/p1-security-hardening). The application now refuses to start with a default JWT secret in non-development environments. See SPARC/auth.py.

Closing as already implemented. JWT startup guard was added in PR #27 (feature/p1-security-hardening). The application now refuses to start with a default JWT secret in non-development environments. See SPARC/auth.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#683
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?