leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #684

New Issue
Closed
opened 2026-03-28 15:21:54 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:21:54 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

api.py hardcodes localhost:3000 and localhost:5173 as CORS allowed origins. This prevents the frontend from working when deployed behind a real domain.

Work to do

  • Introduce a CORS_ALLOWED_ORIGINS environment variable (comma-separated list)
  • Read and parse the variable at startup; fall back to localhost:3000,localhost:5173 in development
  • Replace the hardcoded list in the FastAPI CORS middleware configuration with the parsed value
  • Update .env.example with the new variable and document expected format

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes the API to only allow that origin
  • Omitting the variable in development still allows localhost origins
  • A test or integration check validates that an unlisted origin receives a CORS rejection
## Context Roadmap item: P1 Security hardening `api.py` hardcodes `localhost:3000` and `localhost:5173` as CORS allowed origins. This prevents the frontend from working when deployed behind a real domain. ## Work to do - Introduce a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list) - Read and parse the variable at startup; fall back to `localhost:3000,localhost:5173` in development - Replace the hardcoded list in the FastAPI CORS middleware configuration with the parsed value - Update `.env.example` with the new variable and document expected format ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes the API to only allow that origin - Omitting the variable in development still allows localhost origins - A test or integration check validates that an unlisted origin receives a CORS rejection
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 15:21:54 +00:00
AI-Manager commented 2026-03-28 16:03:15 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. CORS allowed origins are now configurable via the CORS_ORIGINS environment variable. Added in PR #27 (feature/p1-security-hardening). See SPARC/config.py.

Closing as already implemented. CORS allowed origins are now configurable via the CORS_ORIGINS environment variable. Added in PR #27 (feature/p1-security-hardening). See SPARC/config.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?