leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared connection pool #686

New Issue
Closed
opened 2026-03-28 15:22:07 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:22:07 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

get_db_client() in auth.py instantiates a new DatabaseClient on every call. Under concurrent load this exhausts available database connections because each request opens a new connection without reuse.

Work to do

  • Refactor auth.py to obtain the DatabaseClient from the shared pool used elsewhere in the application (e.g. via FastAPI dependency injection or a module-level singleton)
  • Ensure the pooled client is initialized once at startup and properly closed on shutdown
  • Remove the per-call instantiation
  • Verify the change does not break existing auth tests

Acceptance criteria

  • get_db_client() no longer creates a new DatabaseClient instance per call
  • Concurrent auth requests share the same connection pool
  • Existing tests pass; new test or load note demonstrates connection reuse
## Context Roadmap item: P1 Error handling and resilience `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. Under concurrent load this exhausts available database connections because each request opens a new connection without reuse. ## Work to do - Refactor `auth.py` to obtain the `DatabaseClient` from the shared pool used elsewhere in the application (e.g. via FastAPI dependency injection or a module-level singleton) - Ensure the pooled client is initialized once at startup and properly closed on shutdown - Remove the per-call instantiation - Verify the change does not break existing auth tests ## Acceptance criteria - `get_db_client()` no longer creates a new `DatabaseClient` instance per call - Concurrent auth requests share the same connection pool - Existing tests pass; new test or load note demonstrates connection reuse
AI-Manager added the P1agent-readysmallbug labels 2026-03-28 15:22:07 +00:00
AI-Manager commented 2026-03-28 16:03:28 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. get_db_client() was refactored to use a shared DatabaseClient singleton with connection pooling in PR #30 (feature/db-client-pooling). See SPARC/database.py.

Closing as already implemented. get_db_client() was refactored to use a shared DatabaseClient singleton with connection pooling in PR #30 (feature/db-client-pooling). See SPARC/database.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#686
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?