leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #688

New Issue
Closed
opened 2026-03-28 15:22:18 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:22:18 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

The login and register endpoints have no rate limiting, leaving them open to brute-force password attacks and registration spam.

Work to do

  • Add a rate limiting middleware or decorator (e.g. slowapi for FastAPI) to the application
  • Apply limits to /auth/login (e.g. 10 requests per minute per IP) and /auth/register (e.g. 5 requests per minute per IP)
  • Return HTTP 429 with a Retry-After header when the limit is exceeded
  • Make the limits configurable via environment variables (RATE_LIMIT_LOGIN, RATE_LIMIT_REGISTER)
  • Document the new env vars in .env.example

Acceptance criteria

  • Submitting more than the configured number of requests within the window returns 429
  • The rate limit resets after the window expires
  • A test exercises the rate limiting behavior
## Context Roadmap item: P1 Error handling and resilience The login and register endpoints have no rate limiting, leaving them open to brute-force password attacks and registration spam. ## Work to do - Add a rate limiting middleware or decorator (e.g. `slowapi` for FastAPI) to the application - Apply limits to `/auth/login` (e.g. 10 requests per minute per IP) and `/auth/register` (e.g. 5 requests per minute per IP) - Return HTTP 429 with a `Retry-After` header when the limit is exceeded - Make the limits configurable via environment variables (`RATE_LIMIT_LOGIN`, `RATE_LIMIT_REGISTER`) - Document the new env vars in `.env.example` ## Acceptance criteria - Submitting more than the configured number of requests within the window returns 429 - The rate limit resets after the window expires - A test exercises the rate limiting behavior
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 15:22:18 +00:00
AI-Manager commented 2026-03-28 16:03:30 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. Rate limiting was added to /auth/login and /auth/register endpoints in PR #28 (feature/rate-limiting). See SPARC/api.py.

Closing as already implemented. Rate limiting was added to /auth/login and /auth/register endpoints in PR #28 (feature/rate-limiting). See SPARC/api.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#688
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?