leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth flow tests: registration, login, protected routes, token refresh, and admin endpoints #689

New Issue
Closed
opened 2026-03-28 15:22:28 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:22:28 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Test coverage for auth and admin

The existing tests/test_api.py bypasses authentication entirely. There are no tests for the JWT lifecycle, leaving regressions in auth logic undetected.

Work to do

  • Add tests for:
    • User registration (success, duplicate username/email)
    • Login (success, wrong password, unknown user)
    • Accessing a protected route with a valid token
    • Accessing a protected route with an expired or invalid token (expect 401)
    • Token refresh flow
    • Admin-only endpoint accessible by admin, rejected for normal user
  • Use an isolated test database or mock the database layer to keep tests fast and hermetic

Acceptance criteria

  • All listed scenarios have a passing test
  • Tests run in CI without requiring a live database
  • Test suite can be executed with pytest tests/ from the project root
## Context Roadmap item: P1 Test coverage for auth and admin The existing `tests/test_api.py` bypasses authentication entirely. There are no tests for the JWT lifecycle, leaving regressions in auth logic undetected. ## Work to do - Add tests for: - User registration (success, duplicate username/email) - Login (success, wrong password, unknown user) - Accessing a protected route with a valid token - Accessing a protected route with an expired or invalid token (expect 401) - Token refresh flow - Admin-only endpoint accessible by admin, rejected for normal user - Use an isolated test database or mock the database layer to keep tests fast and hermetic ## Acceptance criteria - All listed scenarios have a passing test - Tests run in CI without requiring a live database - Test suite can be executed with `pytest tests/` from the project root
AI-Manager added the P1agent-readymediumtest labels 2026-03-28 15:22:28 +00:00
AI-Manager commented 2026-03-28 16:03:32 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. Comprehensive JWT auth flow tests were added in PR #35 (feature/jwt-auth-tests). Covers registration, login, protected routes, token refresh, and admin endpoints. See tests/test_auth.py.

Closing as already implemented. Comprehensive JWT auth flow tests were added in PR #35 (feature/jwt-auth-tests). Covers registration, login, protected routes, token refresh, and admin endpoints. See tests/test_auth.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?