leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #694

New Issue
Closed
opened 2026-03-28 15:23:04 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:23:04 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend - analyze_single_patent missing download step

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads from disk, but does not download the PDF first. Callers must pre-download the file or the method silently fails.

Work to do

  • Integrate a PDF download step at the start of analyze_single_patent: check if the file exists; if not, download it (reusing the existing download logic used elsewhere in the codebase)
  • Handle download failures with a clear error message
  • Alternatively, if the method is intentionally offline-only, add explicit documentation and a raised exception with a descriptive message when the file is missing

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF has not been downloaded either fetches it automatically or raises a clear FileNotFoundError with a helpful message
  • A test covers both the happy path (file present) and the missing-file case
## Context Roadmap item: P2 Backend - analyze_single_patent missing download step `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads from disk, but does not download the PDF first. Callers must pre-download the file or the method silently fails. ## Work to do - Integrate a PDF download step at the start of `analyze_single_patent`: check if the file exists; if not, download it (reusing the existing download logic used elsewhere in the codebase) - Handle download failures with a clear error message - Alternatively, if the method is intentionally offline-only, add explicit documentation and a raised exception with a descriptive message when the file is missing ## Acceptance criteria - Calling `analyze_single_patent` for a patent whose PDF has not been downloaded either fetches it automatically or raises a clear `FileNotFoundError` with a helpful message - A test covers both the happy path (file present) and the missing-file case
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 15:23:04 +00:00
AI-Manager commented 2026-03-28 16:03:50 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. analyze_single_patent now downloads the PDF before reading from disk. Fixed in PR #55 (feature/fix-single-patent-download).

Closing as already implemented. analyze_single_patent now downloads the PDF before reading from disk. Fixed in PR #55 (feature/fix-single-patent-download).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#694
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?