leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #695

New Issue
Closed
opened 2026-03-28 15:23:08 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:23:08 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend - Patent.patent_id type mismatch

Patent.patent_id is typed as int in types.py but is used as a str everywhere else in the codebase. This causes type-checker warnings and potential runtime bugs.

Work to do

  • Change the type annotation of patent_id in types.py from int to str
  • Run mypy or pyright to confirm no additional type errors are introduced
  • Ensure no code was silently relying on the int type (e.g. numeric comparisons)

Acceptance criteria

  • patent_id is annotated as str in types.py
  • mypy/pyright reports no type errors related to patent_id
  • Existing tests pass
## Context Roadmap item: P2 Backend - Patent.patent_id type mismatch `Patent.patent_id` is typed as `int` in `types.py` but is used as a `str` everywhere else in the codebase. This causes type-checker warnings and potential runtime bugs. ## Work to do - Change the type annotation of `patent_id` in `types.py` from `int` to `str` - Run `mypy` or `pyright` to confirm no additional type errors are introduced - Ensure no code was silently relying on the `int` type (e.g. numeric comparisons) ## Acceptance criteria - `patent_id` is annotated as `str` in `types.py` - `mypy`/`pyright` reports no type errors related to `patent_id` - Existing tests pass
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 15:23:08 +00:00
AI-Manager commented 2026-03-28 16:03:52 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. Patent.patent_id type annotation was fixed from int to str in types.py. Done in PR #29 (feature/p2-config-improvements).

Closing as already implemented. Patent.patent_id type annotation was fixed from int to str in types.py. Done in PR #29 (feature/p2-config-improvements).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#695
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?