leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to reuse a pooled DatabaseClient #70

New Issue
Closed
opened 2026-03-26 14:21:43 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 14:21:43 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py creates a new DatabaseClient instance on every call. This bypasses the connection pool and can exhaust database connections under load.

Work

  • Identify how DatabaseClient manages its connection pool.
  • Refactor get_db_client() to return a module-level or application-scoped singleton client, using FastAPI dependency injection (Depends) where appropriate.
  • Ensure the client is properly closed on application shutdown using a lifespan handler.
  • Verify no other module has the same pattern and fix those too if found.

Acceptance Criteria

  • A single DatabaseClient instance is shared across all auth requests.
  • The client is cleanly closed when the application shuts down.
  • Existing auth-related tests still pass.
  • A basic load test (10 concurrent login requests) does not produce connection errors.

References

Roadmap: Error handling and resilience — get_db_client() creates new client on every call.

## Context `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every call. This bypasses the connection pool and can exhaust database connections under load. ## Work - Identify how `DatabaseClient` manages its connection pool. - Refactor `get_db_client()` to return a module-level or application-scoped singleton client, using FastAPI dependency injection (`Depends`) where appropriate. - Ensure the client is properly closed on application shutdown using a lifespan handler. - Verify no other module has the same pattern and fix those too if found. ## Acceptance Criteria - A single `DatabaseClient` instance is shared across all auth requests. - The client is cleanly closed when the application shuts down. - Existing auth-related tests still pass. - A basic load test (10 concurrent login requests) does not produce connection errors. ## References Roadmap: Error handling and resilience — `get_db_client()` creates new client on every call.
AI-Manager added the P1agent-readymedium labels 2026-03-26 14:21:43 +00:00
AI-Manager commented 2026-03-26 15:05:53 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. DatabaseClient now uses a ThreadedConnectionPool singleton pattern. Implemented in PR #30 (merged). See SPARC/database.py.

Resolved. `DatabaseClient` now uses a `ThreadedConnectionPool` singleton pattern. Implemented in PR #30 (merged). See `SPARC/database.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#70
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?