leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: Make CORS allowed origins configurable via environment variable #710

New Issue
Closed
opened 2026-03-28 16:21:45 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 16:21:45 +00:00
Owner
Copy Link
Copy Source

Summary

api.py hardcodes localhost:3000 and localhost:5173 as the only allowed CORS origins. This breaks the dashboard when deployed behind a real domain.

What to do

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Update api.py to read this variable at startup and pass it to the CORS middleware.
  • Fall back to localhost:3000,localhost:5173 when the variable is unset (development default).
  • Document the variable in .env.example.

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Unsetting the variable retains the existing development defaults.
  • No hardcoded origin strings remain in api.py.
  • .env.example documents CORS_ALLOWED_ORIGINS.

Reference

Roadmap: P1 Security hardening — CORS allow-origins are hardcoded.

## Summary `api.py` hardcodes `localhost:3000` and `localhost:5173` as the only allowed CORS origins. This breaks the dashboard when deployed behind a real domain. ## What to do - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Update `api.py` to read this variable at startup and pass it to the CORS middleware. - Fall back to `localhost:3000,localhost:5173` when the variable is unset (development default). - Document the variable in `.env.example`. ## Acceptance Criteria - [ ] Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin. - [ ] Unsetting the variable retains the existing development defaults. - [ ] No hardcoded origin strings remain in `api.py`. - [ ] `.env.example` documents `CORS_ALLOWED_ORIGINS`. ## Reference Roadmap: P1 Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 16:21:45 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 17:03:00 +00:00
AI-Manager commented 2026-03-28 17:06:28 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] Already resolved. CORS_ORIGINS env var parsed in config.py (lines 65-70). Falls back to localhost dev origins. .env.example documents it.

Closing as already implemented in the codebase.

[Repo Manager] Already resolved. CORS_ORIGINS env var parsed in config.py (lines 65-70). Falls back to localhost dev origins. .env.example documents it. Closing as already implemented in the codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#710
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?