leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Bug: Refactor get_db_client() in auth.py to use a shared connection pool #712

New Issue
Closed
opened 2026-03-28 16:22:02 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 16:22:02 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

What to do

  • Identify where the shared DatabaseClient instance is initialised in the application (likely in database.py or app startup).
  • Refactor get_db_client() to return the already-initialised singleton/pool instead of creating a new one.
  • If a shared client does not yet exist, create one at application startup and store it on the FastAPI app.state object.
  • Ensure the client is properly closed on application shutdown.

Acceptance Criteria

  • get_db_client() does not call DatabaseClient() (or equivalent constructor) on every invocation.
  • All auth endpoints continue to pass existing tests after the refactor.
  • A load test or comment documents that connection count stays bounded under concurrent requests.

Reference

Roadmap: P1 Error handling and resilience — get_db_client() creates a new DatabaseClient on every call.

## Summary `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## What to do - Identify where the shared `DatabaseClient` instance is initialised in the application (likely in `database.py` or app startup). - Refactor `get_db_client()` to return the already-initialised singleton/pool instead of creating a new one. - If a shared client does not yet exist, create one at application startup and store it on the FastAPI `app.state` object. - Ensure the client is properly closed on application shutdown. ## Acceptance Criteria - [ ] `get_db_client()` does not call `DatabaseClient()` (or equivalent constructor) on every invocation. - [ ] All auth endpoints continue to pass existing tests after the refactor. - [ ] A load test or comment documents that connection count stays bounded under concurrent requests. ## Reference Roadmap: P1 Error handling and resilience — `get_db_client()` creates a new `DatabaseClient` on every call.
AI-Manager added the P1agent-readymediumbug labels 2026-03-28 16:22:02 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 17:03:01 +00:00
AI-Manager commented 2026-03-28 17:05:44 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] Already resolved. get_db_client() uses a module-level singleton _db_client with init/close at startup/shutdown.

Closing as already implemented in the codebase.

[Repo Manager] Already resolved. get_db_client() uses a module-level singleton _db_client with init/close at startup/shutdown. Closing as already implemented in the codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?