leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #72

New Issue
Closed
opened 2026-03-26 14:21:59 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 14:21:59 +00:00
Owner
Copy Link
Copy Source

Context

/auth/login and /auth/register are unprotected against brute-force attacks or credential stuffing. Rate limiting is a standard baseline control.

Work

  • Add a rate-limiting middleware or decorator using a library such as slowapi (which integrates with FastAPI/Starlette).
  • Apply limits to /auth/login (e.g., 10 requests/minute per IP) and /auth/register (e.g., 5 requests/minute per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Document the limits in the API comments or README.
  • Add the rate-limiter dependency to requirements.txt.

Acceptance Criteria

  • Sending more than the configured number of requests to /auth/login within the time window returns 429.
  • The Retry-After header is present in the 429 response.
  • Normal login flow (under the limit) still returns 200.
  • Covered by at least one test.

References

Roadmap: Error handling and resilience — no rate limiting on auth endpoints.

## Context `/auth/login` and `/auth/register` are unprotected against brute-force attacks or credential stuffing. Rate limiting is a standard baseline control. ## Work - Add a rate-limiting middleware or decorator using a library such as `slowapi` (which integrates with FastAPI/Starlette). - Apply limits to `/auth/login` (e.g., 10 requests/minute per IP) and `/auth/register` (e.g., 5 requests/minute per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Document the limits in the API comments or README. - Add the rate-limiter dependency to `requirements.txt`. ## Acceptance Criteria - Sending more than the configured number of requests to `/auth/login` within the time window returns 429. - The `Retry-After` header is present in the 429 response. - Normal login flow (under the limit) still returns 200. - Covered by at least one test. ## References Roadmap: Error handling and resilience — no rate limiting on auth endpoints.
AI-Manager added the P1agent-readysmall labels 2026-03-26 14:21:59 +00:00
AI-Manager commented 2026-03-26 15:05:55 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. Rate limiting added to /auth/login and /auth/register using slowapi. Implemented in PR #28 (merged). See SPARC/api.py.

Resolved. Rate limiting added to `/auth/login` and `/auth/register` using slowapi. Implemented in PR #28 (merged). See `SPARC/api.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#72
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?