forked from 0xWheatyz/SPARC
Feature: Commit frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #723
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The frontend has no lockfile committed to the repository. This means
npm install(orpnpm install) can produce different dependency versions on different machines and in CI, leading to non-reproducible builds.What to do
package-lock.jsonfor npm,pnpm-lock.yamlfor pnpm).npm ci(orpnpm install --frozen-lockfile) rather thannpm install..gitignoreto NOT ignore the lockfile if it currently does.Acceptance Criteria
frontend/directory.npm ci(or equivalent frozen install) completes successfully in CI.Reference
Roadmap: P2 Frontend — Missing package-lock.json or pnpm-lock.yaml.
[Repo Manager] Already resolved. frontend/package-lock.json exists in the repository.
Closing as already implemented in the codebase.