leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

CI: Add ruff linting and tsc --noEmit type checking to CI pipeline #725

New Issue
Closed
opened 2026-03-28 16:24:04 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 16:24:04 +00:00
Owner
Copy Link
Copy Source

Summary

There is no linting or type checking in the CI pipeline. Code style regressions and TypeScript type errors can merge undetected.

What to do

  • Add a lint job (or extend the test job) that runs:
    • ruff check . for Python linting.
    • tsc --noEmit in the frontend/ directory for TypeScript type checking.
  • Fix any pre-existing lint or type errors so the pipeline starts green.
  • Gate the build job on lint passing.

Acceptance Criteria

  • ruff check . passes on the current codebase.
  • tsc --noEmit passes on the current frontend codebase.
  • Both checks run in CI on every push and PR.
  • The build job does not run if lint fails.

Reference

Roadmap: P2 CI/CD — No linting or type checking.

## Summary There is no linting or type checking in the CI pipeline. Code style regressions and TypeScript type errors can merge undetected. ## What to do - Add a `lint` job (or extend the `test` job) that runs: - `ruff check .` for Python linting. - `tsc --noEmit` in the `frontend/` directory for TypeScript type checking. - Fix any pre-existing lint or type errors so the pipeline starts green. - Gate the `build` job on `lint` passing. ## Acceptance Criteria - [ ] `ruff check .` passes on the current codebase. - [ ] `tsc --noEmit` passes on the current frontend codebase. - [ ] Both checks run in CI on every push and PR. - [ ] The build job does not run if lint fails. ## Reference Roadmap: P2 CI/CD — No linting or type checking.
AI-Manager added the P2agent-readysmallinfra labels 2026-03-28 16:24:04 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 17:03:16 +00:00
AI-Manager commented 2026-03-28 17:06:05 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] Already resolved. .gitea/workflows/test.yaml runs ruff check and tsc --noEmit.

Closing as already implemented in the codebase.

[Repo Manager] Already resolved. .gitea/workflows/test.yaml runs ruff check and tsc --noEmit. Closing as already implemented in the codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#725
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?