leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth integration tests covering registration, login, and protected routes #73

New Issue
Closed
opened 2026-03-26 14:22:10 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 14:22:10 +00:00
Owner
Copy Link
Copy Source

Context

Existing API tests in tests/test_api.py bypass authentication entirely. There is no test coverage for the JWT flow, leaving security regressions undetected.

Work

  • Add a tests/test_auth.py (or equivalent) that tests:
    • User registration (success and duplicate-user cases).
    • Login with valid credentials (returns access token).
    • Login with invalid credentials (returns 401).
    • Accessing a protected route with a valid token (succeeds).
    • Accessing a protected route without a token (returns 401).
    • Accessing an admin-only endpoint as a regular user (returns 403).
    • Token refresh flow if implemented.
  • Use pytest fixtures for a test database and test client.
  • Ensure tests are isolated and do not pollute production data.

Acceptance Criteria

  • All new tests pass in CI.
  • Coverage for auth.py reaches at least 80%.
  • Tests run without requiring external services (use test DB or mocks).

References

Roadmap: Test coverage for auth and admin.

## Context Existing API tests in `tests/test_api.py` bypass authentication entirely. There is no test coverage for the JWT flow, leaving security regressions undetected. ## Work - Add a `tests/test_auth.py` (or equivalent) that tests: - User registration (success and duplicate-user cases). - Login with valid credentials (returns access token). - Login with invalid credentials (returns 401). - Accessing a protected route with a valid token (succeeds). - Accessing a protected route without a token (returns 401). - Accessing an admin-only endpoint as a regular user (returns 403). - Token refresh flow if implemented. - Use pytest fixtures for a test database and test client. - Ensure tests are isolated and do not pollute production data. ## Acceptance Criteria - All new tests pass in CI. - Coverage for `auth.py` reaches at least 80%. - Tests run without requiring external services (use test DB or mocks). ## References Roadmap: Test coverage for auth and admin.
AI-Manager added the P1agent-readymedium labels 2026-03-26 14:22:10 +00:00
AI-Manager commented 2026-03-26 15:05:56 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. Comprehensive JWT auth integration tests added covering registration, login, and protected endpoints. Implemented in PR #35 (merged). See tests/test_auth.py.

Resolved. Comprehensive JWT auth integration tests added covering registration, login, and protected endpoints. Implemented in PR #35 (merged). See `tests/test_auth.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#73
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?