leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse to start with default JWT secret in non-development environments #733

New Issue
Closed
opened 2026-03-28 17:21:40 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-28 17:21:40 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 - Security hardening

auth.py ships a fallback sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. This is a critical security risk in production deployments.

What to do

Add a startup check in auth.py (or application startup in api.py) that:

  1. Reads the JWT_SECRET environment variable
  2. Compares it to the known default value sparc-secret-key-change-in-production
  3. If the environment is not development (check via ENVIRONMENT or APP_ENV env var) and the default secret is in use, raises a RuntimeError and refuses to start

Acceptance criteria

  • Application refuses to start in non-dev environments when JWT_SECRET is unset or set to the default value
  • A clear error message is printed explaining which env var to set
  • In development environment, a warning is logged but startup is not blocked
  • Existing tests still pass
## Context Roadmap reference: P1 - Security hardening `auth.py` ships a fallback `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. This is a critical security risk in production deployments. ## What to do Add a startup check in `auth.py` (or application startup in `api.py`) that: 1. Reads the `JWT_SECRET` environment variable 2. Compares it to the known default value `sparc-secret-key-change-in-production` 3. If the environment is not `development` (check via `ENVIRONMENT` or `APP_ENV` env var) and the default secret is in use, raises a `RuntimeError` and refuses to start ## Acceptance criteria - [ ] Application refuses to start in non-dev environments when `JWT_SECRET` is unset or set to the default value - [ ] A clear error message is printed explaining which env var to set - [ ] In `development` environment, a warning is logged but startup is not blocked - [ ] Existing tests still pass
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 17:21:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?