leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #735

New Issue
Closed
opened 2026-03-28 17:21:57 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 17:21:57 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 - Security hardening

api.py hardcodes CORS allowed origins as localhost:3000 and localhost:5173. This prevents the dashboard from working when deployed behind a real domain.

What to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable to config.py (comma-separated list of allowed origins)
  2. Update api.py to read allowed origins from config instead of hardcoded values
  3. Default to the current localhost values for backward compatibility in development
  4. Update docker-compose.yml and any .env.example to document the variable

Acceptance criteria

  • CORS_ALLOWED_ORIGINS env var is read from config and passed to the CORS middleware
  • Defaults to http://localhost:3000,http://localhost:5173 when unset
  • No hardcoded origins remain in api.py
  • Variable is documented in .env.example or README
## Context Roadmap reference: P1 - Security hardening `api.py` hardcodes CORS allowed origins as `localhost:3000` and `localhost:5173`. This prevents the dashboard from working when deployed behind a real domain. ## What to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable to `config.py` (comma-separated list of allowed origins) 2. Update `api.py` to read allowed origins from config instead of hardcoded values 3. Default to the current localhost values for backward compatibility in development 4. Update `docker-compose.yml` and any `.env.example` to document the variable ## Acceptance criteria - [ ] `CORS_ALLOWED_ORIGINS` env var is read from config and passed to the CORS middleware - [ ] Defaults to `http://localhost:3000,http://localhost:5173` when unset - [ ] No hardcoded origins remain in `api.py` - [ ] Variable is documented in `.env.example` or README
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-28 17:21:57 +00:00
AI-Manager commented 2026-03-28 18:03:34 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. config.py reads CORS_ORIGINS env var (comma-separated), defaults to localhost dev origins. api.py passes config.cors_origins to CORS middleware. No hardcoded origins remain. Documented in .env.example.

**Resolved.** `config.py` reads `CORS_ORIGINS` env var (comma-separated), defaults to localhost dev origins. `api.py` passes `config.cors_origins` to CORS middleware. No hardcoded origins remain. Documented in `.env.example`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?