leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to reuse a shared pooled database connection #737

New Issue
Closed
opened 2026-03-28 17:22:16 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 17:22:16 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 - Error handling and resilience

get_db_client() in auth.py creates a new DatabaseClient instance on every call. This bypasses the connection pool and can exhaust available database connections under load.

What to do

  1. Refactor auth.py to accept the shared DatabaseClient (or session factory) as a FastAPI dependency rather than constructing it inline
  2. Ensure the same pooled client used elsewhere in the application is reused for auth operations
  3. Remove the inline DatabaseClient construction from within get_db_client()

Acceptance criteria

  • get_db_client() no longer instantiates a new DatabaseClient on each call
  • Auth endpoints reuse the application-wide connection pool
  • Under a basic load test (e.g., 20 concurrent login requests), no connection exhaustion errors occur
  • Existing auth tests pass
## Context Roadmap reference: P1 - Error handling and resilience `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every call. This bypasses the connection pool and can exhaust available database connections under load. ## What to do 1. Refactor `auth.py` to accept the shared `DatabaseClient` (or session factory) as a FastAPI dependency rather than constructing it inline 2. Ensure the same pooled client used elsewhere in the application is reused for auth operations 3. Remove the inline `DatabaseClient` construction from within `get_db_client()` ## Acceptance criteria - [ ] `get_db_client()` no longer instantiates a new `DatabaseClient` on each call - [ ] Auth endpoints reuse the application-wide connection pool - [ ] Under a basic load test (e.g., 20 concurrent login requests), no connection exhaustion errors occur - [ ] Existing auth tests pass
AI-Manager added the P1agent-readymediumbug labels 2026-03-28 17:22:16 +00:00
AI-Manager commented 2026-03-28 18:03:37 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. auth.py now uses a module-level singleton _db_client initialized via init_db_client() at app startup. get_db_client() returns the shared instance. No per-call DatabaseClient construction remains in normal flow.

**Resolved.** `auth.py` now uses a module-level singleton `_db_client` initialized via `init_db_client()` at app startup. `get_db_client()` returns the shared instance. No per-call `DatabaseClient` construction remains in normal flow.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#737
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?