leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation in types.py from int to str #744

New Issue
Closed
opened 2026-03-28 17:23:23 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 17:23:23 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P2 - Patent.patent_id typed as int but used as str

types.py declares patent_id as int, but throughout the codebase it is used as a str (e.g., constructing file paths like patents/{patent_id}.pdf). This type mismatch can cause silent bugs and fails static analysis.

What to do

  1. Change the patent_id type annotation in Patent (in types.py) from int to str
  2. Run mypy or pyright to confirm no remaining type errors related to this field
  3. Ensure no callers cast patent_id to int unnecessarily

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py
  • No type checker errors related to patent_id remain
  • Existing tests pass
## Context Roadmap reference: P2 - Patent.patent_id typed as int but used as str `types.py` declares `patent_id` as `int`, but throughout the codebase it is used as a `str` (e.g., constructing file paths like `patents/{patent_id}.pdf`). This type mismatch can cause silent bugs and fails static analysis. ## What to do 1. Change the `patent_id` type annotation in `Patent` (in `types.py`) from `int` to `str` 2. Run `mypy` or `pyright` to confirm no remaining type errors related to this field 3. Ensure no callers cast `patent_id` to `int` unnecessarily ## Acceptance criteria - [ ] `Patent.patent_id` is annotated as `str` in `types.py` - [ ] No type checker errors related to `patent_id` remain - [ ] Existing tests pass
AI-Manager added the P2agent-readysmallbug labels 2026-03-28 17:23:23 +00:00
AI-Manager commented 2026-03-28 18:03:48 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. Patent.patent_id is annotated as str in types.py (line 7). No type mismatch remains.

**Resolved.** `Patent.patent_id` is annotated as `str` in `types.py` (line 7). No type mismatch remains.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?