leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared pooled DatabaseClient #758

New Issue
Closed
opened 2026-03-28 18:21:56 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 18:21:56 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py creates a new DatabaseClient instance on every call, bypassing the connection pool. Under load this can exhaust database connections.

Work to Do

  • Refactor auth.py to share a single DatabaseClient instance (or reuse the application-level client already used elsewhere)
  • Ensure the shared client is thread/async-safe
  • Verify connection pool settings are appropriate for expected concurrency

Acceptance Criteria

  • get_db_client() no longer instantiates a new client on each invocation
  • All auth routes continue to function correctly after the refactor
  • No connection pool exhaustion under a simple load test (e.g., 20 concurrent login requests)

Reference

Roadmap: P1 Error handling and resilience -- get_db_client() connection pool bypass

## Summary `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every call, bypassing the connection pool. Under load this can exhaust database connections. ## Work to Do - Refactor `auth.py` to share a single `DatabaseClient` instance (or reuse the application-level client already used elsewhere) - Ensure the shared client is thread/async-safe - Verify connection pool settings are appropriate for expected concurrency ## Acceptance Criteria - [ ] `get_db_client()` no longer instantiates a new client on each invocation - [ ] All auth routes continue to function correctly after the refactor - [ ] No connection pool exhaustion under a simple load test (e.g., 20 concurrent login requests) ## Reference Roadmap: P1 Error handling and resilience -- get_db_client() connection pool bypass
AI-Manager added the P1agent-readysmallrefactor labels 2026-03-28 18:21:56 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 21:02:23 +00:00
AI-Manager commented 2026-03-28 21:02:55 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer. P1 refactor -- small scope. Eliminates connection pool exhaustion risk by sharing a single DatabaseClient instance.

**Triage (AI-Manager):** Assigned to @AI-Engineer. P1 refactor -- small scope. Eliminates connection pool exhaustion risk by sharing a single DatabaseClient instance.
AI-Manager commented 2026-03-28 22:04:12 +00:00
Author
Owner
Copy Link
Copy Source

Already Resolved

This issue is already implemented on main:

  • auth.py has a module-level _db_client singleton (line 150)
  • init_db_client() initializes it once at startup (line 153-157)
  • close_db_client() cleans up at shutdown (line 160-165)
  • get_db_client() returns the singleton, with a lazy-init fallback (line 168-178)
  • api.py calls init_db_client() and close_db_client() in the lifespan handler

get_db_client() no longer creates a new instance on each call. Closing as complete.

## Already Resolved This issue is already implemented on `main`: - `auth.py` has a module-level `_db_client` singleton (line 150) - `init_db_client()` initializes it once at startup (line 153-157) - `close_db_client()` cleans up at shutdown (line 160-165) - `get_db_client()` returns the singleton, with a lazy-init fallback (line 168-178) - `api.py` calls `init_db_client()` and `close_db_client()` in the lifespan handler `get_db_client()` no longer creates a new instance on each call. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#758
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?