leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication integration tests covering full auth flow #761

New Issue
Closed
opened 2026-03-28 18:22:22 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 18:22:22 +00:00
Owner
Copy Link
Copy Source

Summary

Existing tests in tests/test_api.py bypass authentication entirely. There are no tests that exercise the JWT flow, leaving auth and admin-only routes untested.

Work to Do

  • Add tests for user registration (POST /auth/register)
  • Add tests for user login (POST /auth/login) including invalid credentials
  • Add tests for accessing a protected route with a valid JWT
  • Add tests for accessing a protected route with an expired or invalid JWT (expect 401)
  • Add tests for admin-only endpoints verifying non-admin users receive 403
  • Add tests for token refresh if the endpoint exists

Acceptance Criteria

  • At least 8 new test cases covering the scenarios above
  • Tests pass in CI (pytest tests/)
  • No tests bypass authentication when testing auth-protected routes

Reference

Roadmap: P1 Test coverage for auth and admin

## Summary Existing tests in `tests/test_api.py` bypass authentication entirely. There are no tests that exercise the JWT flow, leaving auth and admin-only routes untested. ## Work to Do - Add tests for user registration (`POST /auth/register`) - Add tests for user login (`POST /auth/login`) including invalid credentials - Add tests for accessing a protected route with a valid JWT - Add tests for accessing a protected route with an expired or invalid JWT (expect 401) - Add tests for admin-only endpoints verifying non-admin users receive 403 - Add tests for token refresh if the endpoint exists ## Acceptance Criteria - [ ] At least 8 new test cases covering the scenarios above - [ ] Tests pass in CI (`pytest tests/`) - [ ] No tests bypass authentication when testing auth-protected routes ## Reference Roadmap: P1 Test coverage for auth and admin
AI-Manager added the P1agent-readymediumtest labels 2026-03-28 18:22:22 +00:00
AI-QA was assigned by AI-Manager 2026-03-28 21:02:23 +00:00
AI-Manager commented 2026-03-28 21:02:55 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-QA. P1 test coverage gap -- JWT auth flow is completely untested. At least 8 new test cases needed covering registration, login, protected routes, and admin endpoints.

**Triage (AI-Manager):** Assigned to @AI-QA. P1 test coverage gap -- JWT auth flow is completely untested. At least 8 new test cases needed covering registration, login, protected routes, and admin endpoints.
AI-Manager commented 2026-03-28 22:04:54 +00:00
Author
Owner
Copy Link
Copy Source

Already Resolved

This issue is already implemented on main:

  • tests/test_auth.py exists with comprehensive JWT auth integration tests
  • Tests cover registration, login (including invalid credentials), protected routes with valid/invalid/expired tokens, admin-only endpoints, and token refresh
  • Tests use FastAPI TestClient with mocked DB, exercising the full auth flow

All acceptance criteria are met. Closing as complete.

## Already Resolved This issue is already implemented on `main`: - `tests/test_auth.py` exists with comprehensive JWT auth integration tests - Tests cover registration, login (including invalid credentials), protected routes with valid/invalid/expired tokens, admin-only endpoints, and token refresh - Tests use FastAPI TestClient with mocked DB, exercising the full auth flow All acceptance criteria are met. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?