leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #770

New Issue
Closed
opened 2026-03-28 18:23:34 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 18:23:34 +00:00
Owner
Copy Link
Copy Source

Summary

There is no linting or type checking in the CI pipeline. Code style regressions and TypeScript type errors can be merged undetected.

Work to Do

  • Add a lint job (or extend the test job) to the CI workflow that:
    • Runs ruff check . for Python linting
    • Runs tsc --noEmit in the frontend directory for TypeScript type checking
  • Fix any existing linting/type errors so CI starts green
  • Make the build job depend on the lint job

Acceptance Criteria

  • ruff check . runs in CI and fails the build on linting errors
  • tsc --noEmit runs in CI and fails the build on type errors
  • No existing linting or type errors remain in the codebase

Reference

Roadmap: P2 CI/CD -- No linting or type checking

## Summary There is no linting or type checking in the CI pipeline. Code style regressions and TypeScript type errors can be merged undetected. ## Work to Do - Add a `lint` job (or extend the `test` job) to the CI workflow that: - Runs `ruff check .` for Python linting - Runs `tsc --noEmit` in the frontend directory for TypeScript type checking - Fix any existing linting/type errors so CI starts green - Make the `build` job depend on the `lint` job ## Acceptance Criteria - [ ] `ruff check .` runs in CI and fails the build on linting errors - [ ] `tsc --noEmit` runs in CI and fails the build on type errors - [ ] No existing linting or type errors remain in the codebase ## Reference Roadmap: P2 CI/CD -- No linting or type checking
AI-Manager added the P2agent-readymediumfeature labels 2026-03-28 18:23:34 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 21:02:31 +00:00
AI-Manager commented 2026-03-28 21:03:14 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer. P2 CI -- add ruff and tsc --noEmit linting jobs. May require fixing existing lint errors first.

**Triage (AI-Manager):** Assigned to @AI-Engineer. P2 CI -- add ruff and tsc --noEmit linting jobs. May require fixing existing lint errors first.
AI-Manager commented 2026-03-28 22:04:46 +00:00
Author
Owner
Copy Link
Copy Source

Already Resolved

This issue is already implemented on main:

  • .gitea/workflows/test.yaml runs ruff check SPARC/ tests/ (line 35)
  • .gitea/workflows/test.yaml runs npx tsc --noEmit (line 56)
  • .gitea/workflows/build.yaml also includes both linting steps in its test job
  • ruff.toml is configured in the repo root

All acceptance criteria are met. Closing as complete.

## Already Resolved This issue is already implemented on `main`: - `.gitea/workflows/test.yaml` runs `ruff check SPARC/ tests/` (line 35) - `.gitea/workflows/test.yaml` runs `npx tsc --noEmit` (line 56) - `.gitea/workflows/build.yaml` also includes both linting steps in its test job - `ruff.toml` is configured in the repo root All acceptance criteria are met. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready feature medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?