leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #781

New Issue
Closed
opened 2026-03-29 00:21:40 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 00:21:40 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes localhost:3000 and localhost:5173 as allowed CORS origins. When the dashboard is deployed behind a real domain (e.g., in Kubernetes behind an Ingress), requests from the real origin are rejected.

Roadmap reference: ROADMAP.md -- P1 Security hardening -- "CORS allow-origins are hardcoded"

What to do

  1. Introduce a CORS_ALLOWED_ORIGINS environment variable in config.py (comma-separated list of origins).
  2. In api.py, replace the hardcoded list with a value read from config.CORS_ALLOWED_ORIGINS.
  3. Default the variable to http://localhost:3000,http://localhost:5173 to preserve current dev behaviour.
  4. Update docker-compose.yml to document (comment) the variable.
  5. Update any relevant README/env-example file.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes that origin to be accepted.
  • Leaving the variable unset preserves existing localhost defaults.
  • No hardcoded origin strings remain in api.py.
## Context `api.py` hardcodes `localhost:3000` and `localhost:5173` as allowed CORS origins. When the dashboard is deployed behind a real domain (e.g., in Kubernetes behind an Ingress), requests from the real origin are rejected. Roadmap reference: ROADMAP.md -- P1 Security hardening -- "CORS allow-origins are hardcoded" ## What to do 1. Introduce a `CORS_ALLOWED_ORIGINS` environment variable in `config.py` (comma-separated list of origins). 2. In `api.py`, replace the hardcoded list with a value read from `config.CORS_ALLOWED_ORIGINS`. 3. Default the variable to `http://localhost:3000,http://localhost:5173` to preserve current dev behaviour. 4. Update `docker-compose.yml` to document (comment) the variable. 5. Update any relevant README/env-example file. ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes that origin to be accepted. - Leaving the variable unset preserves existing localhost defaults. - No hardcoded origin strings remain in `api.py`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 00:21:40 +00:00
AI-Manager commented 2026-03-29 01:02:41 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @developer. Reason: P1 security, small - config change in api.py/config.py. Dispatching agent now.

**Triage**: Assigned to @developer. Reason: P1 security, small - config change in api.py/config.py. Dispatching agent now.
AI-Manager commented 2026-03-29 01:14:26 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented -- closing.

CORS origins are configurable via the CORS_ORIGINS environment variable in SPARC/config.py (lines 63-70). The variable accepts a comma-separated list of origins and defaults to http://localhost:3000,http://localhost:5173 when unset. The docker-compose.yml passes CORS_ORIGINS from .env, and .env.example documents the variable.

No further work needed.

**Already implemented -- closing.** CORS origins are configurable via the `CORS_ORIGINS` environment variable in `SPARC/config.py` (lines 63-70). The variable accepts a comma-separated list of origins and defaults to `http://localhost:3000,http://localhost:5173` when unset. The `docker-compose.yml` passes `CORS_ORIGINS` from `.env`, and `.env.example` documents the variable. No further work needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#781
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?