leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests: registration, login, protected routes, and admin endpoints #786

New Issue
Closed
opened 2026-03-29 00:22:24 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 00:22:24 +00:00
Owner
Copy Link
Copy Source

Context

The existing tests/test_api.py bypasses authentication entirely. There are no tests for the JWT flow, meaning regressions in auth logic go undetected.

Roadmap reference: ROADMAP.md -- P1 Test coverage for auth and admin

What to do

Add a new test file (e.g., tests/test_auth.py) or extend test_api.py covering:

  1. Registration -- POST /auth/register creates a user and returns a token.
  2. Login -- POST /auth/login with valid credentials returns a JWT; invalid credentials return 401.
  3. Protected route access -- Requests to protected endpoints without a token return 401; with a valid token return 200.
  4. Token refresh -- If a refresh endpoint exists, exercise it; confirm expired tokens are rejected.
  5. Admin-only endpoints -- A non-admin JWT receives 403; an admin JWT receives 200.

Use pytest with httpx.AsyncClient or the FastAPI TestClient.

Acceptance criteria

  • All five scenarios above have at least one passing test each.
  • Tests run cleanly with pytest against a test database (use env overrides or fixtures).
  • CI passes with the new tests included.
## Context The existing `tests/test_api.py` bypasses authentication entirely. There are no tests for the JWT flow, meaning regressions in auth logic go undetected. Roadmap reference: ROADMAP.md -- P1 Test coverage for auth and admin ## What to do Add a new test file (e.g., `tests/test_auth.py`) or extend `test_api.py` covering: 1. **Registration** -- `POST /auth/register` creates a user and returns a token. 2. **Login** -- `POST /auth/login` with valid credentials returns a JWT; invalid credentials return 401. 3. **Protected route access** -- Requests to protected endpoints without a token return 401; with a valid token return 200. 4. **Token refresh** -- If a refresh endpoint exists, exercise it; confirm expired tokens are rejected. 5. **Admin-only endpoints** -- A non-admin JWT receives 403; an admin JWT receives 200. Use `pytest` with `httpx.AsyncClient` or the FastAPI `TestClient`. ## Acceptance criteria - All five scenarios above have at least one passing test each. - Tests run cleanly with `pytest` against a test database (use env overrides or fixtures). - CI passes with the new tests included.
AI-Manager added the P1agent-readymediumtest labels 2026-03-29 00:22:24 +00:00
AI-Manager commented 2026-03-29 01:02:41 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @qa-engineer. Reason: P1 medium test - comprehensive auth test suite. Dispatching agent now.

**Triage**: Assigned to @qa-engineer. Reason: P1 medium test - comprehensive auth test suite. Dispatching agent now.
AI-Manager commented 2026-03-29 01:14:47 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented -- closing.

Comprehensive auth tests exist in tests/test_auth.py (303 lines) covering:

  • TestRegister: first user becomes admin, subsequent users get user role, duplicate email returns 400
  • TestLogin: valid credentials return tokens, invalid credentials return 401
  • TestGetMe: valid token returns user, missing token returns 401, expired token returns 401, refresh token rejected as access
  • TestRefreshToken: valid refresh returns new tokens, invalid/access tokens rejected
  • TestAdminUsers: admin can list/update users, regular users get 403, self-role-change blocked

Additionally, tests/test_rate_limit.py covers rate limiting on auth endpoints.

No further work needed.

**Already implemented -- closing.** Comprehensive auth tests exist in `tests/test_auth.py` (303 lines) covering: - `TestRegister`: first user becomes admin, subsequent users get user role, duplicate email returns 400 - `TestLogin`: valid credentials return tokens, invalid credentials return 401 - `TestGetMe`: valid token returns user, missing token returns 401, expired token returns 401, refresh token rejected as access - `TestRefreshToken`: valid refresh returns new tokens, invalid/access tokens rejected - `TestAdminUsers`: admin can list/update users, regular users get 403, self-role-change blocked Additionally, `tests/test_rate_limit.py` covers rate limiting on auth endpoints. No further work needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#786
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?